replace ember-render-modifiers dependency

[stopfstedt]

our template linting library now actively warns against the usage of {{did-insert}}, {{did-update}}, {{will-destroy}} library, see the linting rules ref entry for the motivation behind this https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-at-ember-render-modifiers.md

those modifiers are provided by https://github.com/emberjs/ember-render-modifiers.

we're currently using (abusing?) these modifiers by attaching tasks to them mainly for loading/reloading async data during component initialization.

this is a legacy pattern. we've already moved off of it in several places, using a tracked resources provided by https://github.com/tracked-tools/ember-async-data instead.

however, we still have many components left that are currently adhering to the render-modifier based approach.

replace all remaining instances.

[stopfstedt]

ballpark

stefan@nichtsnutz: ~/dev/projects/frontend on master[$]
$ egrep -r '{{did-(insert|update|will-destroy)' packages/ | egrep -v '(dist|node_modules)' | sort
packages/frontend/app/components/assign-students.hbs:  {{did-insert (perform this.load) @school}}
packages/frontend/app/components/assign-students.hbs:  {{did-update (perform this.load) @school}}
packages/frontend/app/components/bulk-new-users.hbs:    {{did-insert (perform this.load)}}
packages/frontend/app/components/connection-status.hbs:  aria-hidden={{this.isOnline}} {{did-insert this.setup}}
packages/frontend/app/components/courses/new.hbs:    {{did-insert (perform this.load)}}
packages/frontend/app/components/curriculum-inventory/new-report.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/curriculum-inventory/new-sequence-block.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/curriculum-inventory/new-sequence-block.hbs:  {{did-update (perform this.reload) @report @parent.course}}
packages/frontend/app/components/curriculum-inventory/report-header.hbs:  {{did-insert this.load @report}}
packages/frontend/app/components/curriculum-inventory/report-header.hbs:  {{did-update this.load @report}}
packages/frontend/app/components/curriculum-inventory/report-overview.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/curriculum-inventory/report-rollover.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/curriculum-inventory/report-rollover.hbs:  {{did-update (perform this.load) @report}}
packages/frontend/app/components/curriculum-inventory/reports.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/curriculum-inventory/reports.hbs:  {{did-update (perform this.load) @schoolId @programId}}
packages/frontend/app/components/curriculum-inventory/sequence-block-header.hbs:  {{did-insert this.load @sequenceBlock}}
packages/frontend/app/components/curriculum-inventory/sequence-block-header.hbs:  {{did-update this.load @sequenceBlock}}
packages/frontend/app/components/curriculum-inventory/sequence-block-overview.hbs:  {{did-insert (perform this.load) @sequenceBlock}}
packages/frontend/app/components/curriculum-inventory/sequence-block-overview.hbs:  {{did-update (perform this.load) @sequenceBlock @sequenceBlock.course}}
packages/frontend/app/components/curriculum-inventory/sequence-block-session-manager.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/curriculum-inventory/sequence-block-session-manager.hbs:  {{did-update (perform this.load) @sequenceBlock @sessions}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:  {{did-insert (perform this.load) @report}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:      {{did-insert this.setScrollTarget "table1"}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:      {{did-insert this.setScrollTarget "table2"}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:      {{did-insert this.setScrollTarget "table3a"}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:      {{did-insert this.setScrollTarget "table3b"}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:      {{did-insert this.setScrollTarget "table4"}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:      {{did-insert this.setScrollTarget "table5"}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:      {{did-insert this.setScrollTarget "table6"}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:      {{did-insert this.setScrollTarget "table7"}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:      {{did-insert this.setScrollTarget "table8"}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:      {{did-insert this.setScrollTarget "toc"}}
packages/frontend/app/components/curriculum-inventory/verification-preview.hbs:  {{did-update (perform this.load) @report}}
packages/frontend/app/components/global-search-box.hbs:    {{did-insert (set this.searchInputElement)}}
packages/frontend/app/components/global-search.hbs:  {{did-insert (perform this.search) @query}}
packages/frontend/app/components/global-search.hbs:  {{did-update (perform this.search) @query}}
packages/frontend/app/components/ilios-users.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/ilios-users.hbs:  {{did-update (perform this.load) @limit @offset @query}}
packages/frontend/app/components/instructor-group/header.hbs:  {{did-insert this.load}}
packages/frontend/app/components/instructor-group/header.hbs:  {{did-update this.load @instructorGroup.title}}
packages/frontend/app/components/learner-group/header.hbs:  {{did-insert this.load}}
packages/frontend/app/components/learner-group/header.hbs:  {{did-update this.load @learnerGroup}}
packages/frontend/app/components/learner-group/instructor-manager.hbs:  {{did-insert (perform this.load) @learnerGroup}}
packages/frontend/app/components/learner-group/instructor-manager.hbs:  {{did-update (perform this.load) @learnerGroup}}
packages/frontend/app/components/learner-group/root.hbs:    {{did-insert (perform this.load) @learnerGroup @isEditing @isBulkAssigning}}
packages/frontend/app/components/learner-group/root.hbs:    {{did-update (perform this.load) @learnerGroup @isEditing @isBulkAssigning}}
packages/frontend/app/components/locale-chooser.hbs:      {{did-insert this.focusOnFirstItem}}
packages/frontend/app/components/locale-chooser.hbs:    {{did-insert this.setMenuButton}}
packages/frontend/app/components/new-directory-user.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/program/header.hbs:    {{did-insert this.load @program}}
packages/frontend/app/components/program/header.hbs:    {{did-update this.load @program}}
packages/frontend/app/components/program/overview.hbs:  {{did-insert this.load @program}}
packages/frontend/app/components/program/overview.hbs:  {{did-update this.load @program}}
packages/frontend/app/components/program-year/collapsed-objectives.hbs:  {{did-insert (perform this.load) @programYear.programYearObjectives}}
packages/frontend/app/components/program-year/collapsed-objectives.hbs:  {{did-update (perform this.load) @programYear.programYearObjectives}}
packages/frontend/app/components/program-year/objective-list-item-expanded.hbs:  {{did-insert (perform this.load) @objective}}
packages/frontend/app/components/program-year/objective-list-item-expanded.hbs:  {{did-update (perform this.load) @objective @objective.courses}}
packages/frontend/app/components/program-year/objective-list-item.hbs:  {{did-insert this.load @programYearObjective}}
packages/frontend/app/components/program-year/objective-list-item.hbs:  {{did-update this.load @programYearObjective}}
packages/frontend/app/components/program-year/objectives.hbs:  {{did-insert this.load @programYear}}
packages/frontend/app/components/program-year/objectives.hbs:  {{did-update this.load @programYear @programYear.programYearObjectives}}
packages/frontend/app/components/reports/subject/new/academic-year.hbs:      {{did-insert (perform this.setInitialValue)}}
packages/frontend/app/components/reports/subject/new/academic-year.hbs:      {{did-update (perform this.setInitialValue) @school}}
packages/frontend/app/components/reports/subject/new/competency.hbs:      {{did-insert (perform this.setInitialValue)}}
packages/frontend/app/components/reports/subject/new/competency.hbs:      {{did-update (perform this.setInitialValue) @school}}
packages/frontend/app/components/reports/subject/new/instructor-group.hbs:      {{did-insert (perform this.setInitialValue)}}
packages/frontend/app/components/reports/subject/new/instructor-group.hbs:      {{did-update (perform this.setInitialValue) @school}}
packages/frontend/app/components/reports/subject/new/program.hbs:      {{did-insert (perform this.setInitialValue)}}
packages/frontend/app/components/reports/subject/new/program.hbs:      {{did-update (perform this.setInitialValue) @school}}
packages/frontend/app/components/reports/subject/new/program-year.hbs:      {{did-insert (perform this.setInitialValue)}}
packages/frontend/app/components/reports/subject/new/program-year.hbs:      {{did-update (perform this.setInitialValue) @school}}
packages/frontend/app/components/reports/subject/new/session-type.hbs:      {{did-insert (perform this.setInitialValue)}}
packages/frontend/app/components/reports/subject/new/session-type.hbs:      {{did-update (perform this.setInitialValue) @school}}
packages/frontend/app/components/reports/subject/new/term.hbs:      {{did-insert (perform this.setInitialValue)}}
packages/frontend/app/components/reports/subject/new/term.hbs:      {{did-update (perform this.setInitialValue) @school}}
packages/frontend/app/components/school-competencies-collapsed.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/school-competencies-collapsed.hbs:  {{did-update (perform this.load) @school.competencies}}
packages/frontend/app/components/school-competencies-expanded.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/school-competencies-expanded.hbs:  {{did-update (perform this.load) @school.competencies}}
packages/frontend/app/components/school-curriculum-inventory-institution-manager.hbs:    {{did-insert this.load}}
packages/frontend/app/components/school-curriculum-inventory-institution-manager.hbs:    {{did-update this.load @institution}}
packages/frontend/app/components/school/emails-editor.hbs:    {{did-insert this.load}}
packages/frontend/app/components/school/emails-editor.hbs:    {{did-update this.load}}
packages/frontend/app/components/school-manager.hbs:  {{did-insert this.load}}
packages/frontend/app/components/school-session-attributes.hbs:  {{did-insert (perform this.load) @school}}
packages/frontend/app/components/school-session-attributes.hbs:  {{did-update (perform this.load) @school @school.configurations}}
packages/frontend/app/components/school-session-type-form.hbs:    {{did-insert (perform this.load)}}
packages/frontend/app/components/school-session-type-manager.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/school-session-types-collapsed.hbs:  {{did-insert (perform this.load) @school}}
packages/frontend/app/components/school-session-types-collapsed.hbs:  {{did-update (perform this.load) @school}}
packages/frontend/app/components/school-session-types-expanded.hbs:  {{did-insert (perform this.load) @school}}
packages/frontend/app/components/school-session-types-expanded.hbs:  {{did-update (perform this.load) @school @school.sessionTypes}}
packages/frontend/app/components/school-vocabularies-expanded.hbs:  {{did-insert (perform this.load) @school}}
packages/frontend/app/components/school-vocabularies-expanded.hbs:  {{did-update (perform this.load) @school @school.vocabularies}}
packages/frontend/app/components/school-vocabulary-manager.hbs:    {{did-insert this.load}}
packages/frontend/app/components/school-vocabulary-term-manager.hbs:    {{did-insert this.load @term}}
packages/frontend/app/components/school-vocabulary-term-manager.hbs:    {{did-update this.load @term}}
packages/frontend/app/components/unassigned-students-summary.hbs:    {{did-insert (perform this.load) this.schoolId}}
packages/frontend/app/components/unassigned-students-summary.hbs:    {{did-update (perform this.load) this.schoolId}}
packages/frontend/app/components/user-menu.hbs:    {{did-insert (set this.element)}}
packages/frontend/app/components/user-menu.hbs:          <li tabindex="-1" data-test-item {{did-insert this.focus}}>
packages/frontend/app/components/user-profile-bio.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/user-profile-bio.hbs:  {{did-update (perform this.load) @user @isManaging}}
packages/frontend/app/components/user-profile-cohorts.hbs:  {{did-insert (perform this.load) @user}}
packages/frontend/app/components/user-profile-roles.hbs:  {{did-insert (perform this.load)}}
packages/frontend/app/components/user-profile-roles.hbs:  {{did-update (perform this.load) @user.roles}}
packages/frontend/app/components/visualizer-program-year-objectives.hbs:  {{did-insert (perform this.load) @programYear}}
packages/frontend/app/components/visualizer-program-year-objectives.hbs:  {{did-update (perform this.load) @programYear}}
packages/ilios-common/addon/components/api-version-notice.hbs:  {{did-insert (perform this.check)}}
packages/ilios-common/addon/components/choose-material-type.hbs:      {{did-insert (set this.menuElement)}}
packages/ilios-common/addon/components/choose-material-type.hbs:      {{did-insert this.focusOnFirstItem}}
packages/ilios-common/addon/components/course/collapsed-objectives.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/course/collapsed-objectives.hbs:  {{did-update (perform this.load) @course.courseObjectives}}
packages/ilios-common/addon/components/course-header.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/course-header.hbs:  {{did-update this.revertTitleChanges}}
packages/ilios-common/addon/components/course/objective-list.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/course/objective-list.hbs:  {{did-update (perform this.load) @course}}
packages/ilios-common/addon/components/course/objective-list-item.hbs:  {{did-insert this.load @courseObjective}}
packages/ilios-common/addon/components/course/objective-list-item.hbs:  {{did-update this.load @courseObjective}}
packages/ilios-common/addon/components/course/objectives.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/course/objectives.hbs:  {{did-update (perform this.load) @course}}
packages/ilios-common/addon/components/course-overview.hbs:  {{did-insert (perform this.load) @course}}
packages/ilios-common/addon/components/course-overview.hbs:  {{did-update (perform this.load) @course}}
packages/ilios-common/addon/components/course/publication-menu.hbs:      {{did-insert (set this.menuElement)}}
packages/ilios-common/addon/components/course/publication-menu.hbs:      {{did-insert this.focusOnFirstItem}}
packages/ilios-common/addon/components/course/rollover-date-picker.hbs:  {{did-insert (perform this.showPicker) @course @value}}
packages/ilios-common/addon/components/course/rollover-date-picker.hbs:  {{did-update (perform this.showPicker) @course @value}}
packages/ilios-common/addon/components/course-rollover.hbs:  {{did-insert (perform this.load) @course}}
packages/ilios-common/addon/components/course-rollover.hbs:  {{did-update (perform this.load) @course}}
packages/ilios-common/addon/components/course-summary-header.hbs:  {{did-insert (perform this.load) @course}}
packages/ilios-common/addon/components/course-summary-header.hbs:  {{did-update (perform this.load) @course}}
packages/ilios-common/addon/components/course-visualizations.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/course-visualize-instructors.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/course-visualize-session-type.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/course-visualize-term.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/daily-calendar-event.hbs:  {{did-insert (set this.theElement)}}
packages/ilios-common/addon/components/daily-calendar.hbs:    {{did-insert (perform this.scrollView) this.earliestHour}}
packages/ilios-common/addon/components/daily-calendar.hbs:    {{did-update (perform this.scrollView) this.earliestHour}}
packages/ilios-common/addon/components/daily-calendar.hbs:        <span aria-hidden="true" class="hour hour-{{hour.hour}}" {{did-insert this.setHour hour.hour}}>
packages/ilios-common/addon/components/dashboard/calendar.hbs:      {{did-insert (perform this.loadEvents) this.bestSelectedSchool this.fromTimeStamp this.toTimeStamp @mySchedule}}
packages/ilios-common/addon/components/dashboard/calendar.hbs:      {{did-update (perform this.loadEvents) this.bestSelectedSchool this.fromTimeStamp this.toTimeStamp @mySchedule}}
packages/ilios-common/addon/components/dashboard/courses-calendar-filter.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/dashboard/courses-calendar-filter.hbs:  {{did-insert (set this.el)}}
packages/ilios-common/addon/components/dashboard/courses-calendar-filter.hbs:          {{did-insert this.scrollToLastYear year.year}}
packages/ilios-common/addon/components/dashboard/courses-calendar-filter.hbs:  {{did-update (perform this.load) @school}}
packages/ilios-common/addon/components/dashboard/filter-tags.hbs:    {{did-insert (perform this.load) this.activeFilters}}
packages/ilios-common/addon/components/dashboard/filter-tags.hbs:    {{did-update (perform this.load) this.activeFilters}}
packages/ilios-common/addon/components/date-picker.hbs:  {{did-insert (perform this.setupPicker)}}
packages/ilios-common/addon/components/date-picker.hbs:  {{did-update (perform this.updatePicker) @value @maxDate @minDate}}
packages/ilios-common/addon/components/detail-cohort-list.hbs:  {{did-insert (perform this.load) @cohorts}}
packages/ilios-common/addon/components/detail-cohort-list.hbs:  {{did-update (perform this.load) @cohorts}}
packages/ilios-common/addon/components/detail-competencies.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/detail-competencies.hbs:  {{did-update (perform this.load) @course.competencies}}
packages/ilios-common/addon/components/detail-learning-materials.hbs:    <div class="title" {{did-insert (set this.title)}}>
packages/ilios-common/addon/components/detail-mesh.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/detail-mesh.hbs:  {{did-update (perform this.load) @subject.meshDescriptors}}
packages/ilios-common/addon/components/detail-terms-list.hbs:  {{did-insert (perform this.load) @terms}}
packages/ilios-common/addon/components/detail-terms-list.hbs:  {{did-update (perform this.load) @terms}}
packages/ilios-common/addon/components/detail-terms-list-item.hbs:  {{did-insert (set this.theElement)}}
packages/ilios-common/addon/components/editable-field.hbs:        {{did-insert this.focusFirstControl}}
packages/ilios-common/addon/components/html-editor.hbs:  {{did-insert (perform this.loadEditor) this.options}}
packages/ilios-common/addon/components/html-editor.hbs:  {{did-update (perform this.loadEditor) this.options}}
packages/ilios-common/addon/components/ilios-calendar-event-month.hbs:  {{did-insert (set this.theElement)}}
packages/ilios-common/addon/components/ilios-course-details.hbs:  {{did-insert (set this.topSection)}}
packages/ilios-common/addon/components/ilios-tooltip.hbs:    {{did-insert this.setup}}
packages/ilios-common/addon/components/learningmaterial-manager.hbs:  {{did-insert (perform this.load) @learningMaterial}}
packages/ilios-common/addon/components/learningmaterial-manager.hbs:  {{did-update (perform this.load) @learningMaterial}}
packages/ilios-common/addon/components/mesh-manager.hbs:          {{did-insert (set this.searchInput)}}
packages/ilios-common/addon/components/offering-calendar.hbs:  {{did-insert (perform this.load) this.startDate this.endDate @learnerGroups @session}}
packages/ilios-common/addon/components/offering-calendar.hbs:  {{did-update (perform this.load) this.startDate this.endDate @learnerGroups @session}}
packages/ilios-common/addon/components/offering-form.hbs:  {{did-insert (perform this.load) @offering @cohorts}}
packages/ilios-common/addon/components/offering-form.hbs:  {{did-update (perform this.load) @offering @cohorts}}
packages/ilios-common/addon/components/offering-manager.hbs:              {{did-insert this.setLearnerGroupElement learnerGroup.id}}
packages/ilios-common/addon/components/offering-url-display.hbs:      {{did-insert (set this.copyButton)}}
packages/ilios-common/addon/components/print-course.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/print-course.hbs:  {{did-update (perform this.load) @course.sessions @course.learningMaterials}}
packages/ilios-common/addon/components/search-box.hbs:    {{did-insert (set this.searchInput)}}
packages/ilios-common/addon/components/selectable-terms-list-item.hbs:  {{did-insert (set this.theElement)}}
packages/ilios-common/addon/components/session/collapsed-objectives.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/session/collapsed-objectives.hbs:  {{did-update (perform this.load) @session.sessionObjectives}}
packages/ilios-common/addon/components/session-copy.hbs:  {{did-insert (perform this.setup) @session}}
packages/ilios-common/addon/components/session-copy.hbs:  {{did-update (perform this.setup) @session}}
packages/ilios-common/addon/components/session/objective-list-item.hbs:  {{did-insert this.load @sessionObjective}}
packages/ilios-common/addon/components/session/objective-list-item.hbs:  {{did-update this.load @sessionObjective}}
packages/ilios-common/addon/components/session/objectives.hbs:  {{did-insert (perform this.load) }}
packages/ilios-common/addon/components/session/objectives.hbs:  {{did-update (perform this.load) @session}}
packages/ilios-common/addon/components/session-offerings-list.hbs:  {{did-insert (perform this.load)}}
packages/ilios-common/addon/components/session-offerings-list.hbs:  {{did-update (perform this.load) @session}}
packages/ilios-common/addon/components/session-overview.hbs:  {{did-insert (perform this.load) @session}}
packages/ilios-common/addon/components/session-overview.hbs:  {{did-update (perform this.load) @session}}
packages/ilios-common/addon/components/session/postrequisite-editor.hbs:  {{did-insert (perform this.setup) @session}}
packages/ilios-common/addon/components/session/postrequisite-editor.hbs:  {{did-update (perform this.setup) @session}}
packages/ilios-common/addon/components/session/publication-menu.hbs:      {{did-insert (set this.menuElement)}}
packages/ilios-common/addon/components/session/publication-menu.hbs:      {{did-insert this.focusOnFirstItem}}
packages/ilios-common/addon/components/sessions-grid.hbs:  {{did-insert this.scrollDown}}
packages/ilios-common/addon/components/sessions-grid-offering.hbs:  {{did-insert (set this.row)}}
packages/ilios-common/addon/components/sessions-grid-offering.hbs:  {{did-insert this.revertRoomChanges}}
packages/ilios-common/addon/components/sessions-grid-offering.hbs:  {{did-update this.revertRoomChanges}}
packages/ilios-common/addon/components/taxonomy-manager.hbs:  {{did-insert this.load @vocabulary}}
packages/ilios-common/addon/components/user-name-info.hbs:      {{did-insert (set this.theElement)}}
packages/ilios-common/addon/components/wait-saving.hbs:    <div tabindex="-1" class="content" data-test-content {{did-insert (set this.contentElement)}}>
packages/ilios-common/addon/components/weekly-calendar-event.hbs:  {{did-insert (set this.theElement)}}
packages/ilios-common/addon/components/weekly-calendar.hbs:    {{did-insert (perform this.scrollView) this.earliestHour}}
packages/ilios-common/addon/components/weekly-calendar.hbs:    {{did-update (perform this.scrollView) this.earliestHour}}
packages/ilios-common/addon/components/weekly-calendar.hbs:        <span aria-hidden="true" class="hour hour-{{hour.hour}}" {{did-insert this.setHour hour.hour}}>

[michaelchadwick]

I was looking at a template and VSCode was complaining about this, so I searched to see if anyone else noticed, and lo and behold. I did not realize that there were so many instances of it, though :-O