Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getOwner deprecation in frontend repo. #5302

Open
stopfstedt opened this issue Mar 7, 2024 · 1 comment
Open

fix getOwner deprecation in frontend repo. #5302

stopfstedt opened this issue Mar 7, 2024 · 1 comment

Comments

@stopfstedt
Copy link
Member

stopfstedt commented Mar 7, 2024

example:
image

find and replace all instances of

import { getOwner } from '@ember/application';

with

import { getOwner } from '@ember/owner';

as an aside - I can't find this deprecation listed on Ember's Deprecation sub-site, and the Ember docs still list the deprecated import pattern in their example.
Might be good to file a ticket and patch for that while at it.

@stopfstedt stopfstedt changed the title fix getOwner deprecation in frontend repos. fix getOwner deprecation in frontend repo. Mar 7, 2024
@michaelchadwick
Copy link
Contributor

I don't actually get this deprecation notice with Ember 5.8.1 and Node 20.12.2.

The only places I can find that mentions this is emberjs/ember.js@03bdc4c and emberjs/ember.js#19680.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants