Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support freezegun fake types #481

Closed
nhairs opened this issue May 5, 2024 · 0 comments
Closed

Support freezegun fake types #481

nhairs opened this issue May 5, 2024 · 0 comments
Labels

Comments

@nhairs
Copy link

nhairs commented May 5, 2024

freezegun is a utility library commonly used in testing to control the time. In doing so it causes the datetime library to produce fake types.

Although these types correctly identify themselves as instances of their relevant type, orjson does not identify them as such leading to errors.

Although it would be possible to use the default argument, this may not always be feasible for the calling library. It would be great if orjson could natively support these.

>>> import datetime
>>> import freezegun.api
>>> isinstance(freezegun.api.FakeDate(2024,5,5), datetime.date)
True
>>> isinstance(freezegun.api.FakeDatetime(2024, 5, 5), datetime.datetime)
True
>>> import datetime
>>> import freezegun.api
>>> import orjson
>>> now = datetime.datetime.now()
>>> orjson.dumps(now)
b'"2023-08-21T11:29:54.532301"'
>>> orjson.dumps(freezegun.api.datetime_to_fakedatetime(now))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: Type is not JSON serializable: FakeDatetime
@nhairs nhairs changed the title Support freezegun Fake types Support freezegun fake types May 5, 2024
@github-actions github-actions bot added the Stale label May 12, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant