New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WARC-Block-Digest and WARC-Payload-Digest examples are invalid #64

Open

ato opened this issue Apr 30, 2020 · 0 comments

Labels

WARC/1.1-possible-errata

Member

ato commented Apr 30, 2020 •

edited

Section 5.8 and 5.9 in the WARC 1.1 spec include the following two examples:

WARC-Block-Digest: sha1:AB2CD3EF4GH5IJ6KL7MN8OPQ
WARC-Payload-Digest: sha1:3EF4GH5IJ6KL7MN8OPQAB2CD

These are invalid because:

The character "8" is not part of the Base32 alphabet.
The strings are of length 24. The SHA-1 function produces 160-bit output which when encoded as a Base32 string should be 160 / 5 = 32 characters long.

Note that the additional examples in Annex B do not suffer from these problems:

WARC-Block-Digest: sha1:2ASS7ZUZY6ND6CCHXETFVJDENAWF7KQ2
WARC-Payload-Digest: sha1:CCHXETFVJD2MUZY6ND6SS7ZENMWF7KQ2

The text was updated successfully, but these errors were encountered:

ato added the WARC/1.1-possible-errata label

ato added a commit that referenced this issue


          WARC/1.1 annotated: invalid digest examples #64

f9bba88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment