Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 16-bit image support for edge detection class #624

Open
ihhub opened this issue Jan 13, 2020 · 0 comments
Open

Add 16-bit image support for edge detection class #624

ihhub opened this issue Jan 13, 2020 · 0 comments
Labels
core Core image processing code good first issue An issue is perfectly suitable for first comers. A very minimal knowledge of the project is required improvement Upgrade existing feature unit tests Project related unit tests
Milestone

Comments

@ihhub
Copy link
Owner

ihhub commented Jan 13, 2020

We have edge detection code located in src/edge_detection.h and src/edge_detection.cpp files. We would like to add a support of Image16Bit class which is 16-bit unsigned integer based image. Steps are needed to be done:

  1. Modify this function
    template <typename _Type>
    void findEdgePoints( const penguinV::Image & image, uint32_t x, uint32_t y, uint32_t width, uint32_t height, const EdgeParameter & edgeParameter,
                         std::vector < PointBase2D<_Type> > & positiveEdgePoint, std::vector < PointBase2D<_Type> > & negativeEdgePoint )

To work with any type of images. It means replace penguinV::Image by penguinV::ImageTemplate<_ImageType> and make further modifications of the code inside the function.

  1. Add needed overloaded instances of find functions in EdgeDetectionHelper class only for new type of the image
  2. Add needed overloaded instances of find functions in EdgeDetectionBase class only for new type of the image
  3. Modify test/unit_tests/unit_test_edge_detection.cpp functions to accept any type of images.
@ihhub ihhub added improvement Upgrade existing feature unit tests Project related unit tests good first issue An issue is perfectly suitable for first comers. A very minimal knowledge of the project is required core Core image processing code labels Jan 13, 2020
@ihhub ihhub added this to the Release milestone Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core image processing code good first issue An issue is perfectly suitable for first comers. A very minimal knowledge of the project is required improvement Upgrade existing feature unit tests Project related unit tests
Projects
None yet
Development

No branches or pull requests

1 participant