-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use 'better' logic for updating vertex attributes #1330
Draft
maelle
wants to merge
5
commits into
main
Choose a base branch
from
dup
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+272
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
maelle
commented
Mar 29, 2024
maelle
commented
Mar 29, 2024
maelle
commented
Apr 2, 2024
maelle
commented
Apr 2, 2024
maelle
commented
Apr 2, 2024
krlmlr
reviewed
Apr 2, 2024
krlmlr
reviewed
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good.
@clpippel: what do you think?
tmp[index] <- value[[i]] | ||
value[[i]] <- tmp | ||
} | ||
index_is_natural_sequence <- (length(index) == vcount(graph) && all(index == V(graph))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
index_is_natural_sequence <- (length(index) == vcount(graph) && all(index == V(graph))) | |
index_is_natural_sequence <- (length(index) == vcount(graph) && identical(index, seq_len(vcount(graph)))) |
krlmlr
changed the title
refactor: use 'better' logic
refactor: use 'better' logic for updating vertex attributes
May 23, 2024
@clpippel friendly reminder if you have time and want to have a look 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1327