Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky sanitizer builds #1311

Open
krlmlr opened this issue Mar 19, 2024 · 5 comments
Open

Flaky sanitizer builds #1311

krlmlr opened this issue Mar 19, 2024 · 5 comments
Assignees
Labels
bug an unexpected problem or unintended behavior c code
Milestone

Comments

@krlmlr
Copy link
Contributor

krlmlr commented Mar 19, 2024

What happens, and what did you expect instead?

Only about 3 out of 10 runs for the sanitizer actually succeed, most others die with a segfault. I believe this has started when we turned on running the sanitizer for examples.

To reproduce

https://github.com/igraph/rigraph/actions/workflows/build-and-check.yml

System information

No response

@krlmlr krlmlr added this to the upkeep milestone Mar 19, 2024
@krlmlr krlmlr added bug an unexpected problem or unintended behavior c code labels Mar 19, 2024
@szhorvat
Copy link
Member

Could be due to randomness in some examples? Segfault still indicates a bug though, this should be checked ...

@krlmlr
Copy link
Contributor Author

krlmlr commented Mar 19, 2024

The segfaults sometimes occur during an odd stage, though -- during package installation.

@Antonov548
Copy link
Contributor

I have investigated it a bit.
The problem is occurred after running this pipeline with introduced memory leak. #1286

Then it creates cache of the GHA and when it's used segfaults happens during installation. So, cleaning of the cache for GHA fix this problem. I guess we should just dissable caching for this step. Not sure how caching is working with the steps which use docker containers.

@krlmlr
Copy link
Contributor Author

krlmlr commented Mar 20, 2024

I don't see a cache created on GHA.

@Antonov548
Copy link
Contributor

I don't see a cache created on GHA.

I just removed it to test more this theory. But locally I don't see segfault in the docker container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior c code
Projects
None yet
Development

No branches or pull requests

3 participants