Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix builds with the develop branch of igraph/C #1296

Open
krlmlr opened this issue Mar 12, 2024 · 3 comments · May be fixed by #1299
Open

Fix builds with the develop branch of igraph/C #1296

krlmlr opened this issue Mar 12, 2024 · 3 comments · May be fixed by #1299
Assignees
@Antonov548
Labels
c code
Milestone
upgrade-2

Comments

@krlmlr
Copy link
Contributor

krlmlr commented Mar 12, 2024

Switch the igraph/C repo to the develop branch, run tools/update-cigraph.sh . This leads to compilation errors that need to be fixed.

Can we make this our priority?
@krlmlr krlmlr added the c code label Mar 12, 2024
@krlmlr krlmlr added this to the upgrade-2 milestone Mar 12, 2024
@krlmlr krlmlr linked a pull request Mar 12, 2024 that will close this issue
Draft
@szhorvat
Copy link
Member

It makes sense to do this on a separate branch.

Moving to more auto-generation might make this considerably easier.

@Antonov548
Copy link
Contributor

It makes sense to do this on a separate branch.

Moving to more auto-generation might make this considerably easier.

Sorry, I maybe out of the context.

Is develop branch in C/igraph is upcoming release? Because I tried to build R/igraph with this branch and there is quite some issues, tests are failing and also I found some problems in the C/igraph in this branch. Should I create pull request to develop branch?

@szhorvat
Copy link
Member

Is develop branch in C/igraph is upcoming release?

It will become version 1.0, and has many breaking changes compared to 0.10. However, these breaking changes should be easy to adapt to on the R side, nothing like what happened between 0.9 and 0.10.

I suggest that the rigraph repository should also have a develop branch where compatibility updates are made gradually, in tandem with how the develop branch of the C library evolves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Antonov548 Antonov548

Labels
c code
Projects
None yet
Milestone
upgrade-2
3 participants
@szhorvat @krlmlr @Antonov548