Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for limit #656

Open
therji-motif opened this issue Jan 19, 2024 · 1 comment
Open

Documentation for limit #656

therji-motif opened this issue Jan 19, 2024 · 1 comment

Comments

@therji-motif
Copy link

The documentation for limit is sparse, and I for some reason thought it would enforce the heap to keep the top N values. Instead, I'm not actually quite sure what it's doing, or what some practical purposes are for it? Some clarity here would be great, as sometimes my test results with limit returned "correctly" (but it was purely by chance).

@ignlg
Copy link
Owner

ignlg commented Feb 24, 2024

Thanks for your feedback @therji-motif . I will review the implementation and update the documentation accordingly. My apologies for the inaccuracy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants