Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY data files #41

Open
igneus opened this issue Sep 12, 2018 · 0 comments
Open

DRY data files #41

igneus opened this issue Sep 12, 2018 · 0 comments

Comments

@igneus
Copy link
Owner

igneus commented Sep 12, 2018

We have a lot of files sharing the same calendar data and only differing in localized feast names. Let's make it possible to load a calendar from two files, one containing the shared structure (date, rank, colour, symbol) and another one mapping symbols to feast names.

Note: at first it may look like a good idea to move sanctorale feast names to i18n - especially when temporale feast names are already there. (And pejulian/romcal goes more or less this way, too.) But this would make it impossible or very complicated to work with two calendars, using the same locale and having different names for the same feast. This is often the case when one of the calendars is diocesan and the other religious.

igneus added a commit that referenced this issue Jul 11, 2020
Celebration titles (the only piece of information differing between the
localized files) moved to config/locale.

resolves #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant