Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement react-autosuggest alternative #2170

Open
LMulvey opened this issue Oct 13, 2022 · 8 comments
Open

Implement react-autosuggest alternative #2170

LMulvey opened this issue Oct 13, 2022 · 8 comments

Comments

@LMulvey
Copy link
Contributor

LMulvey commented Oct 13, 2022

Description

react-autosuggest is no longer maintained and has deprecated code that conflicts with our testing utilities, React Testing Library (@testing-library/react).

react-autosuggest still checks for event.keyCode, which is long since deprecated. testing-library/user-event stopped supporting as of v14 and now overwrites keyCode to 0 (only to support React's SyntheticEvents which expect a value for keyCode).

There are many alternatives out there but I would personally suggest downshift as it is well-maintained, well-supported, and quite scalable. The learning curve to get everything up-and-running can take a bit, but once you have your components established, it "just works". Plus, it has the benefit of being created and maintained by Kent C. Dodds, the creator/maintainer of React Testing Library.

Reproduction Steps

See #2166 discussion for more details

Screenshots


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

@MuhammadAakash
Copy link
Contributor

Hi, sir @LMulvey
can you please be more specific with this issue like what we have to do, and in what fields or components we have to replace the react-autosuggest with downshift?
And I would love to work on this issue.

Thanks.

@julianguyen
Copy link
Member

Hey @MuhammadAakash, I haven't looked at https://github.com/downshift-js/downshift too deeply, but at first glance it looks like a good, maintained alternative to switch to. Feel free to take this on and investigate further!

@MuhammadAakash MuhammadAakash self-assigned this Nov 4, 2022
@sfayyad sfayyad assigned sfayyad and unassigned sfayyad Nov 10, 2022
@pauluzo
Copy link

pauluzo commented Nov 19, 2022

Hi @MuhammadAakash is there any progress on this issue? I'd love to work on it

@MuhammadAakash
Copy link
Contributor

Hi @pauluzo.
If you want to work just start working on it

@MuhammadAakash
Copy link
Contributor

MuhammadAakash commented Nov 20, 2022

@pauluzo
I have assigned this issue to you, feel free to reach out to us on slack if you have any query.

@pauluzo
Copy link

pauluzo commented Nov 20, 2022

@MuhammadAakash thanks. I'll reach out on slack.

@lucas-codes-stuff
Copy link

@julianguyen do you know of any progress that has been made on this?

@julianguyen
Copy link
Member

No progress @lucas-codes-stuff ! You can start from scratch here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants