Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Storybook build to our Circle CI configuration #2163

Open
julianguyen opened this issue Oct 9, 2022 · 7 comments
Open

Add a Storybook build to our Circle CI configuration #2163

julianguyen opened this issue Oct 9, 2022 · 7 comments

Comments

@julianguyen
Copy link
Member

Description

Let's add a Storybook build to our Circle CI configuration. We need to verify that merges to our repo do not break the Storybook build. If there are changes to files in /client, we want to verify that the Storybook build passes before a PR is mergeable.


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

@cristianmedeiros
Copy link

Will give it a try

@julianguyen
Copy link
Member Author

That would be great, thank you, @cristianmedeiros!

@rajat-tomar
Copy link

@cristianmedeiros are you working on this?

@cristianmedeiros
Copy link

cristianmedeiros commented Oct 17, 2022 via email

@rajat-tomar
Copy link

Hi Rajat, yes, slowly, but yes

On Mon, Oct 17, 2022 at 11:13 AM Rajat Tomar @.> wrote: @cristianmedeiros https://github.com/cristianmedeiros are you working on this? — Reply to this email directly, view it on GitHub <#2163 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIAT6AN73ZSYLB3YHB6TTWDVNIHANCNFSM6AAAAAARAYLLA4 . You are receiving this because you were mentioned.Message ID: @.>

Ohh ok! just wanted to confirm. Thanks for confirming @cristianmedeiros !😊

@cristianmedeiros
Copy link

hi @rajat-tomar I probably won't finish it today to hacktoberfest, do you want to assing this issue for you?

@rajat-tomar
Copy link

It's okay @cristianmedeiros, Hacktoberfest is anyways ending now. You should give it one more shot. For now, I'm working on some other priority projects. Just let me know if you need any help regarding this else I'll be happy to pick this up this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants