Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

only add requested beams for required variables #471

Open
JessicaS11 opened this issue Nov 14, 2023 · 0 comments
Open

only add requested beams for required variables #471

JessicaS11 opened this issue Nov 14, 2023 · 0 comments
Labels
afternoon_contribution This issue should be resolvable in an afternoon or so of work. bug Something isn't working help wanted Extra attention is needed

Comments

@JessicaS11
Copy link
Member

JessicaS11 commented Nov 14, 2023

Thanks for working on a fix @JessicaS11!

馃帀

I tried this out and it runs smoothly for a single ATL08 file, multiple ATL08 files, and multiple ATL06 files. I'm getting an error trying to read ATL03 files, but I think that one may be a me problem because I get the same error using version 0.8.0.

馃槙

Looking at the output the ATL08 produces I am not seeing what I expected, but I also may just be misunderstanding. The output ds from the code in #469 (used reader.vars.append(beam_list=['gt1l', 'gt3r'], var_list=['h_canopy', "latitude", "longitude"])) was:

Screenshot 2023-11-14 at 9 06 06 AM

My confusions:

  1. Shouldn't h_canopy be a Data Variable?
  2. Shouldn't only gt1l and gt3r be listed in gt?

If you want to brainstorm together @JessicaS11 just let me know.

Originally posted by @rwegener2 in #470 (comment)

During preparations for a tutorial using ATL08 and consequent debugging of data read in of ATL08, it was noted that all beams are coordinates in the resulting DataArray, even if only select beams were requested. Looking at reader.vars.wanted after the reader.vars.append line noted above and it looks like the other beams are being added via the mandatory rgt variable... (so, for instance, gt2l/land_segments/rgt is being added even though gt2l/land_segments/h_canopy is not. Thus, all of the beams are ending up in the dimension/index/coordinate list.

This issue will require diving into how internal calls to vars.append to include required variables can also be limited to the requested beams.

@JessicaS11 JessicaS11 added bug Something isn't working help wanted Extra attention is needed afternoon_contribution This issue should be resolvable in an afternoon or so of work. labels Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
afternoon_contribution This issue should be resolvable in an afternoon or so of work. bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant