You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At L361, it says `if spatial_extent.split(".")[-1] in ["kml", "shp", "gpkg"]:` which restricts the possible file types to KMLs, shapefiles and geopackages. However at L114, the code uses `gpd.read_file(spatial_extent)`, which should mean that any other OGR supported vector file format should work (e.g. GeoJSON, FlatGeoBuf, etc).
Do you think it's possible to remove the hardcoded file extension check at L361? Maybe a try-except statement to see if the file can be read directly into a geopandas.GeoDataFrame?
Theoretically, the NSIDC subsetter should accept any vector file that is also supported by OGR. We'd like to remove the file format restrictions, but need to add some more tests/confirm that this tracks.
See also the brief discussion in the PR.
The text was updated successfully, but these errors were encountered:
Do you think it's possible to remove the hardcoded file extension check at L361? Maybe a try-except statement to see if the file can be read directly into a
geopandas.GeoDataFrame
?Originally posted by @weiji14 in #331 (comment)
Theoretically, the NSIDC subsetter should accept any vector file that is also supported by OGR. We'd like to remove the file format restrictions, but need to add some more tests/confirm that this tracks.
See also the brief discussion in the PR.
The text was updated successfully, but these errors were encountered: