Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "search in this collection" slot in virtual collections #1172

Open
GVogeler opened this issue Nov 24, 2023 · 1 comment
Open

remove "search in this collection" slot in virtual collections #1172

GVogeler opened this issue Nov 24, 2023 · 1 comment

Comments

@GVogeler
Copy link
Collaborator

GVogeler commented Nov 24, 2023

mom-ca offers a general "search in this collection" widget in the collections / fonds menu. In aggregated collections like https://www.monasterium.net/mom/DO/collection and in collections with hooked-in charters this does not work as search uses the current collcetion/fonds identifier for constraint.
Entry point to code:

<div>
<xrx:i18n>
<xrx:key>search-in-collection</xrx:key>
<xrx:default>Search in this collection</xrx:default>
</xrx:i18n>
<form style="padding:0;" action="{conf:param('request-root') }search?">
<input id="search-field" name="q" type="text" value="{request:get-parameter('q', '')}"/>
<input type="hidden" name="context" value="{$wgoto-search:id}"/>
<input id="search-trigger" type="submit" value="{i18n:value('search', $xrx:lang, 'Search')}"/>
</form>
</div>

@GVogeler
Copy link
Collaborator Author

GVogeler commented Nov 24, 2023

There are probable two options:

  1. remove this slot in case of aggregated collections
  2. include a computed index methods (exist-trigger) to create an internal representation of these aggregationes

The second solution could also solve the problem with hooked-in charters, but it is a substantial effort. I would therefore prefer the first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant