You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DateAsText uses CultureInfo.InvariantCulture by default, if no other format provider is given.
Actual Behavior
DateAsText uses CultureInfo.CurrentCulture by default, if no other format provider is given. This is inconsistent with other classes such as DateOf, NumberOf and TextOf, which all use CultureInfo.InvariantCulture.
Mention any other details that might be useful
Also, there is only one constructor that lets us specify a different format provider:
publicDateAsText(IScalar<DateTime> date, IText format, IFormatProvider provider)
This is inconvenient in a lot of situations, because the date needs to be wrapped in an IScalar and the format needs to be wrapped in an IText. Maybe we should add these ctors:
publicDateAsText(DateTime date, string format, IFormatProvider provider)publicDateAsText(DateTime date, IFormatProvider provider)
Steps to reproduce the behavior
The log given by the failure.
The text was updated successfully, but these errors were encountered:
Expected Behavior
DateAsText
usesCultureInfo.InvariantCulture
by default, if no other format provider is given.Actual Behavior
DateAsText
usesCultureInfo.CurrentCulture
by default, if no other format provider is given. This is inconsistent with other classes such asDateOf
,NumberOf
andTextOf
, which all useCultureInfo.InvariantCulture
.Mention any other details that might be useful
Also, there is only one constructor that lets us specify a different format provider:
This is inconvenient in a lot of situations, because the date needs to be wrapped in an
IScalar
and the format needs to be wrapped in anIText
. Maybe we should add these ctors:Steps to reproduce the behavior
The log given by the failure.
The text was updated successfully, but these errors were encountered: