Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change key configuration name to reflect behavior #15

Open
iamgollum opened this issue May 1, 2020 · 0 comments
Open

Change key configuration name to reflect behavior #15

iamgollum opened this issue May 1, 2020 · 0 comments
Assignees
@iamgollum
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@iamgollum
Copy link
Collaborator

iamgollum commented May 1, 2020 •
edited

Observation

The intended behavior was to have header support for keyName and keyValue. However, it was deemed un-necessary since the JDBC Sink should be responsible for mapping the key to the payload for the index writer strategy and not the source connector.

Action Item

Rename keyValue to just Key
@iamgollum iamgollum added enhancement New feature or request good first issue Good for newcomers labels May 1, 2020
@iamgollum iamgollum self-assigned this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamgollum iamgollum

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iamgollum