Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CCSID parameter to the connector configuration #125

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add CCSID parameter to the connector configuration #125

wants to merge 5 commits into from

Conversation

theodore-evans
Copy link

@theodore-evans theodore-evans commented Dec 15, 2023 •
edited

Description

Fixes #124

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

No additional tests added for this feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@theodore-evans theodore-evans mentioned this pull request Dec 15, 2023
Open
@theodore-evans theodore-evans marked this pull request as draft December 18, 2023 10:43
@theodore-evans
Copy link
Author

theodore-evans commented Dec 18, 2023 •
edited

I have put this PR back into draft status, as this connector as it stands does not populating missing configuration values with defaults in the standard way--i.e. defining a subclass of AbstractConfiguration (see step 1 of https://www.confluent.io/blog/create-dynamic-kafka-connect-source-connectors/)

This means that changes as they are will cause the connector to fail where no mq.ccsid config value is set. A fix with default handling for this field is upcoming.

@theodore-evans-sst
add ccsid parameter to config parsing and JMSReader configuration
5136978 
Signed-off-by: Theodore Evans <tjdcevans@gmail.com>
@theodore-evans-sst
Add entry for ccsid configuration to documentation
16fcb5c 
Signed-off-by: Theodore Evans <tjdcevans@gmail.com>
@theodore-evans-sst
Add default ccsid of 819
5ea22d0 
Signed-off-by: Theodore Evans <tjdcevans@gmail.com>
Florian Lorenzen added 2 commits December 21, 2023 12:42
@theodore-evans-sst
Fix default handling of CCSID
65fd16e 
Signed-off-by: Florian Lorenzen <florian.lorenzen@posteo.de>
@theodore-evans-sst
Use username/password authentication to test IBM MQ in the integratio…
8ef3f44 
…n tests

The commit ibm-messaging/mq-container@a8ff0a5 changed the handlin gof passwords for the developer configuration. Therefore, it is necessary to explicitly set them in the container environment and for the client properties.

Signed-off-by: Florian Lorenzen <florian.lorenzen@posteo.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💡 [Feature] - Ability to set CCSID for MQ connector to non-default value
2 participants
@theodore-evans @theodore-evans-sst