Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and fix dro and uds task and pipeline design #1147

Closed
alequint opened this issue Dec 18, 2023 · 0 comments
Closed

Review and fix dro and uds task and pipeline design #1147

alequint opened this issue Dec 18, 2023 · 0 comments
Assignees
Labels
Tekton Issues related to Tekton

Comments

@alequint
Copy link
Contributor

Fix provided for #1146 is a work around that we must revisit

We are making dro role accept an action that it does not support, to be then skipped afterwards. That is because uds_action is passed today to both uds and dro task steps, which is also a poor design given that these tasks are mutually exclusive.

Suggested Solution:

  • Create a Tasks in CLI to cover dro: today we have only one here covering uds. Then move dro step to the new task
  • Create a taskdef to invoke new dro task and add it into install and install-with-fvt pipelines. Add a when clause in dro taskdef to guarantee it runs only when uds_action is install-dro
  • Add a when clause in uds taskdef to guarantee it runs only when uds_action is install
  • Remove install action as a valid one from dro role (i.e. revert the workaround)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tekton Issues related to Tekton
Projects
None yet
Development

No branches or pull requests

4 participants