Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwoPane layout #894

Closed
mwz opened this issue Oct 9, 2019 · 7 comments · Fixed by #1124
Closed

TwoPane layout #894

mwz opened this issue Oct 9, 2019 · 7 comments · Fixed by #1124

Comments

@mwz
Copy link
Contributor

mwz commented Oct 9, 2019

Hi, would it be possible to implement a TwoPane layout from XMonad? This layout is very similar to the Tall layout, except that there is only one window showed on the secondary pane and any additional windows in this layout can be cycled through (on the secondary pane).

@ianyh
Copy link
Owner

ianyh commented Oct 9, 2019

Possible, but I’m inclined to wait for #51 before adding new layouts.

@mwz
Copy link
Contributor Author

mwz commented Oct 11, 2019

It seems that this would be much easier to implement than a generic functionality for handling user-defined layouts, especially that this layout is probably a simpler version of Tall or the column layouts.

Are you open for external contributions or do you strictly want to wait for #51?

@cgtz
Copy link

cgtz commented Oct 27, 2019

I implemented something like this, but reversed (windows stacked on the main pane instead of secondary) in #897 by slightly adapting TallLayout. @ianyh, are you open to merging new layouts like this or do you still want to wait for #51? Is #51 currently being worked on?

@ianyh
Copy link
Owner

ianyh commented Oct 27, 2019

Yeah, I think contributions would be fine. I just don’t have the bandwidth myself.

@x-ji
Copy link
Contributor

x-ji commented Aug 17, 2020

Any update on this? A TwoPane layout like the one from XMonad would be really nice. I could also give it a try if you're open to PRs.

Alternatively, @cgtz are you interested in finishing the PR you opened a while ago? I think that would achieve something very similar.

@mwz
Copy link
Contributor Author

mwz commented Jun 9, 2021

hey all, I've got this layout working locally - I will tidy up the code, write some tests and try to open a PR soon.

@mwz
Copy link
Contributor Author

mwz commented Jun 14, 2021

Ok, here's the PR #1124.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants