Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's needed for focus follows mouse? #543

Closed
ScottOaks opened this issue Jan 26, 2017 · 6 comments
Closed

What's needed for focus follows mouse? #543

ScottOaks opened this issue Jan 26, 2017 · 6 comments
Labels

Comments

@ScottOaks
Copy link

ScottOaks commented Jan 26, 2017

I realize that this feature is experimental, but I cannot get it to work at all. The only preferences I have changed from default is to remove all layouts except floating, and enable focus follows mouse. Is there some other dependency I am missing here?

I guess it might not work for certain apps, but it has not worked for the ones I have tried, which are terminal, realvnc, and safari.

Trello Card

@ianyh
Copy link
Owner

ianyh commented Jan 30, 2017

It should definitely work for those apps. I just tried it, though, and it is definitely behaving erratically. Do you have any external displays? Does it work with any layouts besides floating?

@ianyh ianyh added the bug label Jan 30, 2017
@ScottOaks
Copy link
Author

It is not working with any of those apps on just my primary display (macbook pro early 2015). Though also today I've hooked up two external monitors, but no difference.

However, I've switched from realvnc to Mac ScreenSharing, and it does sort of work among the different windows of that app (though not reliably -- e.g., it will change the focus when moving from window A to B, but not from B to A). So at least I'm on the write path in the config. Though also, still not from ScreenSharing to any other app.

Using tall layout doesn't change the situation.

@vlerenc
Copy link

vlerenc commented Feb 13, 2017

Maybe unrelated issue (not sure), but definitely similar to #398 (MacBook Pro late 2016, macOS 10.12.3 (16D32), two monitors, was trying tall and floating). The feature doesn't work on monitor 1 for me at all, but works perfectly on monitor 2 (including moving the mouse from monitor 1 to monitor 2; moving it back to monitor 1 or any movement on monitor 1 yields no focus change).

That feature would be totally awesome (being used to *nix). Sad, Macs don't have it, so if you have any clues how to make it work, that would be really much appreciated! Thanks a lot in advance!

@koekeishiya
Copy link

koekeishiya commented Feb 13, 2017

@ianyh I ran into what could be the same problem a long time ago, when I did focus-follows-mouse, see issue for reference.

Having the Dock visible made focus-follows-mouse not work on the display that showed the Dock.

In short, having the Dock always visible caused the window-server to always report an (invisible ?) window in the first index, with the same size as the primary display resolution. The window has kCGWindowOwnerName set to Dock and kCGWindowName set to Dock, and I used that information to simply ignore it.

@ianyh
Copy link
Owner

ianyh commented Feb 14, 2017

@koekeishiya Thank you so much! I would have spent ages trying to track that down.

@vlerenc
Copy link

vlerenc commented Feb 14, 2017

Yes, I came to the same conclusion when thinking about the differences between the "monitors". After switching to show/hide dock it started to work for me also on monitor 1 (with the now usually hidden dock). Thank you @koekeishiya for even posting a possible solution.

@ianyh If I may, is it possible on macOS (I am new to it) to implement the feature also without auto-raise? Coming from Unix environments, I always used focus-follows-mouse, but never auto-raise as this is often breaking certain interactions with new windows/dialogs that pop up over a window your mouse happens to be over. Being able to selectively enable or disable auto-raise would be really awesome therefore, I believe.

ianyh added a commit that referenced this issue Jul 21, 2017
There's all sorts of crazy windows in crazy situations that are not visible to the user, but are visible to accessibility.

Fixes #543
ianyh added a commit that referenced this issue Jul 21, 2017
There's all sorts of crazy windows in crazy situations that are not visible to the user, but are visible to accessibility.

Fixes #543
ianyh added a commit that referenced this issue Aug 23, 2017
There's all sorts of crazy windows in crazy situations that are not visible to the user, but are visible to accessibility.

Fixes #543
ianyh added a commit that referenced this issue Mar 9, 2019
* Retry adding application observers on failure

Fixes #49

* Migrate to swift 4

* always swap if there are only 2 windows

* check Xcode version, don't check for Carthage, relax rbenv

* Allow for commands that are not configured by a configuration file

Fixes #603

* Register handlers for all possible layout commands

* Pull out window initial floating logic into a helper method

* improve my my proofreading skills

* Add a code of conduct

* Update pod for preferences window to non-deprecated version

* Add a shortcut handler for closing the preferences window

Fixes #622

* Fit window frame to screen frame if necessary on screen changes

Fixes #569

* When getting top window only consider available windows

There's all sorts of crazy windows in crazy situations that are not visible to the user, but are visible to accessibility.

Fixes #543

* Only attempt to display preferences if preferences isn't visible

* Increment version for 0.11.4 first beta

* Update donating section of the README

Just remove the direct donation option, and update the Patreon description to add that the money will be donated.

* Fix a bug that would prevent selecting apps for floating

Fixes #636

* Increment version for Amethyst 0.11.4 beta 2

* Increment version for 0.11.4

* Clean up the config storage interface and fix tests

* Changes to travis config for updates

* Trying circleci

* Generalize the floating bundle id wildcards via regex

Fixes #531

* Updating travis config

* Add a "Reviewed by Hound" badge

* Put the +/- floating app buttons over table

* Add more detailed floating preferences to UserConfiguration

* Allow `id` as a variable name

* Add floating by window title to preferences

* Prevent editing bundle identifiers inline

* Remove the generic window title on preferences

* Make FloatingBundle correctly equatable

* Use a different library for login item toggling

Fixes #673

* Fix the coordinate adjustment in ffm manager

Fixes #706

* Adjust mouse locations to Amethyst coordinate system

* Increment version for 0.12.2 beta

* Actually float windows by title

* Increment version for 0.12.2 beta 2

* Use correct value transformers for selected floating app

* Preserve object arrangements in floating bundle apps on changes

* Increment version for 0.12.2 beta 3

* Correct the logic for whitelisting

Fixes #758

* Lint tests as well as application code

* Increment version for 0.12.2 beta 4

* Final 0.12.2 version

* Fix the GeneralPreferencesViewController.xib

There was a bad merge somewhere

* Increment version to 0.12.3 beta 1

* Increment version for 0.12.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants