Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and properly route unsupported browsers. #18

Open
ianramzy opened this issue Apr 12, 2020 · 2 comments
Open

Detect and properly route unsupported browsers. #18

ianramzy opened this issue Apr 12, 2020 · 2 comments
Labels
enhancement Improves an existing feature

Comments

@ianramzy
Copy link
Owner

Right now the detection of unsupported browsers is sketchy at best. In the future feature, detection would be the way to go as @joepio suggested.

Maybe this library could help: https://github.com/muaz-khan/DetectRTC

Specific cases that need to be tested: Internet explorer, Older version of Edge, The built-in browsers in mobile apps such as Facebook, Messenger, Twitter, and Snapchat
@ianramzy ianramzy mentioned this issue Apr 12, 2020
Closed
@ianramzy
Copy link
Owner Author

I have addressed basic redirection using user agents in 6101706, which is good enough for now. But feature detection is the real goal here, so I am going to leave this issue open.

@Chaphasilor Chaphasilor added the enhancement Improves an existing feature label Apr 17, 2020
@ianramzy
Copy link
Owner Author

  • Snapchat mobile browser on iOS is no routed to /notsupportedios
  • Unsupported versions of edge are not rerouted properly

There needs to be feature detection to determine which browsers are not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improves an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chaphasilor @ianramzy