Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate button doesn’t work on safari for iOS and iPadOS #651

Open
dramrarafa opened this issue Oct 13, 2023 · 8 comments
Open

Generate button doesn’t work on safari for iOS and iPadOS #651

dramrarafa opened this issue Oct 13, 2023 · 8 comments

Comments

@dramrarafa
Copy link

Also tried chrome on both os but no luck, any ideas?

thx

@MaxQuatro
Copy link

+Edge

@ghscuuo
Copy link

ghscuuo commented Oct 21, 2023

What version?
Did it used to work?
Maybe post some screenshots or videos?
Try incognito mode?
Try guest mode?
Can browser dev tools help shed light on what's going on?

@MaxQuatro
Copy link

MaxQuatro commented Oct 21, 2023

Ipados 16.7.1 ipad pro 11’ 4 gen, EDGE 118.0.2088.60 (and also in safari and firefox), bip39 page (0.5.6) “generate” button not work
There are no problems with version 0.5.4 (with the downloaded file)

@ghscuuo
Copy link

ghscuuo commented Oct 22, 2023

Good to hear you have a reasonable workaround with version 0.5.4.

How about version 0.5.5?

Maybe ios doesn't like the span class="text-danger"
or the bad grammar: "your your secret"
or maybe the ampersand: copy & paste.

@MaxQuatro
Copy link

Good evening! I checked the work of version 0.5.5 now - the generate button does not work. If I set the entropy or seed myself, then the addresses are calculated.

@ghscuuo
Copy link

ghscuuo commented Oct 22, 2023

Good evening!

That kind of points to this:

    function generateClicked() {
        if (isUsingOwnEntropy()) {
            return;
        }
        // Pressing enter on BIP85 index field triggers generate click event.
        // See https://github.com/iancoleman/bip39/issues/634
        // To cancel the incorrect generation process, stop here if generate is
        // not focused.
        var buttonIsFocused = DOM.generate[0].contains(document.activeElement);
        if (!buttonIsFocused) {
            return;
        }
...

Sorry I won't be much help any more. Someone else will have to help out now. Good luck!

@dramrarafa
Copy link
Author

Also the same with iOS and iPadOS 17 on different browsers

@iancoleman
Copy link
Owner

Thanks for reporting this. Unfortunately I don't have easy access to an iOS device. I've confirmed the generate button doesn't work, but will need some more time or extra help from the community to figure out why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants