Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coin type of binance coin #625

Open
misaqsaadat opened this issue Nov 22, 2022 · 7 comments
Open

coin type of binance coin #625

misaqsaadat opened this issue Nov 22, 2022 · 7 comments

Comments

@misaqsaadat
Copy link

Hello. according to link below, coin type of binance should be 714 (or 9006)
but in the code this is 60. which should be used for ethereum. is there a reason you use 60 for both binance and ether? which make their private key (and addresses) equal?

https://github.com/satoshilabs/slips/blob/master/slip-0044.md

@Uefi1
Copy link

Uefi1 commented Dec 6, 2022

The author of this release died from coronovirus

@misaqsaadat
Copy link
Author

has Ian Coleman passed away?
RIP

@iancoleman
Copy link
Owner

No I haven't passed away.

@misaqsaadat
Copy link
Author

Thanks God
I'm sorry. I thought "author if this release" is referring you. (then who passed away?)
So can you explain why you use 60 for binance?
this is commit link :
42e00ef

@iancoleman
Copy link
Owner

Would have to ask @mvillalba who submitted this change in #442

@mvillalba
Copy link
Contributor

I do not recall why it was set to 60 in my original PR. I'm afraid I haven't done anything relating to this in a long time, and I don't recall the specifics.

@misaqsaadat
Copy link
Author

Some developer inside my company says that we should use '60' for binance, because it is 'standard'. when I ask why is this 'standard' he says because Ian Coleman did this. this number (60) is only duplicate number in list. so there is no obvious reason why you choose to use 60 instead of 714.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants