Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why add amp; in my url #766

Closed
yi1260 opened this issue Jan 28, 2024 · 2 comments
Closed

why add amp; in my url #766

yi1260 opened this issue Jan 28, 2024 · 2 comments
Assignees
Labels
bug Something isn't working no-issue-activity

Comments

@yi1260
Copy link

yi1260 commented Jan 28, 2024

Describe the bug
i use 'additionalPaths' to add my custom url :

image

but i get a result like this:
image

whywhy 'amp;' is added after '&' ?

@yi1260 yi1260 added the bug Something isn't working label Jan 28, 2024
@graemegeorge
Copy link

@yi1260 This functionality was added as a result of #207 where & is not valid for xml generation but does appear in a url. While we probably shouldn't & is still valid in a url in many cases though not ideal. Take a CMS for example, an editor may create a title that produces a slug such as /burger-&-fries who wouldn't be aware of the implications this has on an xml file.

I think in your case, you shouldn't need to include the url search params in your sitemap declaration (correct me if I'm wrong). A sitemap will only require the page route itself, not it's "state", just remove the ?page=1... and you should be good to go. Assuming I'm not missing nay other specifics to your requirement.

Copy link

github-actions bot commented May 8, 2024

Closing this issue due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity
Projects
None yet
Development

No branches or pull requests

3 participants