Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulnerability? #56

Open
iamvery opened this issue Sep 30, 2016 · 1 comment
Open

Vulnerability? #56

iamvery opened this issue Sep 30, 2016 · 1 comment

Comments

@iamvery
Copy link
Owner

iamvery commented Sep 30, 2016 •
edited

Is #21 a concern? It seems to still be problematic...

attributes:

screen shot 2016-09-30 at 8 06 00 am

### rendered markup:

screen shot 2016-09-30 at 8 06 17 am

### click:

screen shot 2016-09-30 at 8 06 40 am

So the question is, does this matter? What if any are the attack vectors? Seems like if there is a concern, it would come inserting user content into these attributes 🤔
@iamvery
Copy link
Owner Author

iamvery commented Sep 30, 2016

After a little more research, this only seems to be a problem if user input is used for attribute names. Values appear to be properly escaped. In general it seems like it's always a bad idea to use user input for attribute names, but it still seems like a vector. Fwiw, similar things can be accomplished with EEx as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iamvery