Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase linkcheck_timeout #192

Merged
merged 2 commits into from Jul 7, 2020
Merged

Increase linkcheck_timeout #192

merged 2 commits into from Jul 7, 2020

Conversation

TylerLoewen
Copy link
Contributor

Increase linkcheck_timeout to try and prevent curl timeout.

Attempt to fix #191

Closes: #191

@TylerLoewen TylerLoewen requested a review from iamed2 July 6, 2020 21:18
@TylerLoewen TylerLoewen self-assigned this Jul 6, 2020
@TylerLoewen
Copy link
Contributor Author

Is this a good value to set the timeout as? I'm assuming the timeout was previously 10 seconds based on this part of the error message in #191 --max-time 10 but that may not be correct.

@iamed2
Copy link
Owner

iamed2 commented Jul 6, 2020

Apparently it's not enough, according to Travis. I don't see a problem with increasing this to 60.

@iamed2 iamed2 merged commit ec99e69 into master Jul 7, 2020
@iamed2 iamed2 deleted the tl/increase-linkcheck-timeout branch July 7, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamed2 iamed2 iamed2 approved these changes

Assignees

@TylerLoewen TylerLoewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

curl failure when building docs
2 participants
@TylerLoewen @iamed2