-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spinner not working consistently for large graphs #688
Comments
I think this is ok now, so I'm closing the issue. |
Can we perhaps put a notice (below the spinner?) that says something like "This might take a while. Please wait..." in case it takes longer than 30 seconds? |
The spinner starts immediately when loading an SBML file to Newt through URL. When loading the file, the file size is checked. If the size is more than 250KB, then the text "Take a sip of your coffee while you wait" is shown too. Otherwise, only the spinner is shown. |
Thanks @SelbiEreshova seems to work fine. Please:
|
For issue: iVis-at-Bilkent/newt#688
Otherwise the response does not contain content-length
Probably after these changes, now when there is no graph element and we click on the layout button, spinner is started but never stopped. |
We use spinner to show the process of both file loading and layout. Ideally, spinner starts when we start loading a file or applying layout and it stops when file has loaded or layout has finished. However, start and stop times of the spinner are currently not correct especially for the large graphs.
For example, while we are loading the below file (please delete .txt before loading), spinner works correctly. However, when we click on the layout button, spinner starts very late and stops at correct time.
central_plant_metabolism_doubled.nwt.txt
Another example is while trying to load a large sbml file from URL. When we try to open the following link, spinner stops after some time, before map appears in the canvas.
https://web.newteditor.org/?URL=https://www.ebi.ac.uk/biomodels/model/download/MODEL1108160000.2?filename=MODEL1108160000_url.xml&inferNestingOnLoad=true&applyLayoutOnURL=true
The text was updated successfully, but these errors were encountered: