Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner not working consistently for large graphs #688

Open
hasanbalci opened this issue Jun 30, 2022 · 5 comments
Open

Spinner not working consistently for large graphs #688

hasanbalci opened this issue Jun 30, 2022 · 5 comments
Assignees

Comments

@hasanbalci
Copy link
Contributor

hasanbalci commented Jun 30, 2022

We use spinner to show the process of both file loading and layout. Ideally, spinner starts when we start loading a file or applying layout and it stops when file has loaded or layout has finished. However, start and stop times of the spinner are currently not correct especially for the large graphs.

For example, while we are loading the below file (please delete .txt before loading), spinner works correctly. However, when we click on the layout button, spinner starts very late and stops at correct time.

central_plant_metabolism_doubled.nwt.txt

Another example is while trying to load a large sbml file from URL. When we try to open the following link, spinner stops after some time, before map appears in the canvas.

https://web.newteditor.org/?URL=https://www.ebi.ac.uk/biomodels/model/download/MODEL1108160000.2?filename=MODEL1108160000_url.xml&inferNestingOnLoad=true&applyLayoutOnURL=true

@hasanbalci
Copy link
Contributor Author

I think this is ok now, so I'm closing the issue.

@ugurdogrusoz
Copy link
Contributor

Can we perhaps put a notice (below the spinner?) that says something like "This might take a while. Please wait..." in case it takes longer than 30 seconds?

@SelbiEreshova
Copy link
Collaborator

The spinner starts immediately when loading an SBML file to Newt through URL. When loading the file, the file size is checked. If the size is more than 250KB, then the text "Take a sip of your coffee while you wait" is shown too. Otherwise, only the spinner is shown.

@ugurdogrusoz
Copy link
Contributor

Thanks @SelbiEreshova seems to work fine. Please:

  • change the text message to include "..." at the end
  • then transfer this to the related master branch(es)
  • let @hasanbalci know so he can do a quick patch release

SelbiEreshova added a commit to iVis-at-Bilkent/sbgnviz.js that referenced this issue Jul 25, 2022
SelbiEreshova added a commit that referenced this issue Jul 25, 2022
SelbiEreshova added a commit that referenced this issue Jul 26, 2022
Otherwise the response does not contain content-length
SelbiEreshova added a commit that referenced this issue Jul 26, 2022
SelbiEreshova added a commit that referenced this issue Jul 26, 2022
SelbiEreshova added a commit that referenced this issue Jul 26, 2022
SelbiEreshova added a commit that referenced this issue Jul 26, 2022
@hasanbalci
Copy link
Contributor Author

Probably after these changes, now when there is no graph element and we click on the layout button, spinner is started but never stopped.

@hasanbalci hasanbalci removed their assignment Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants