Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show hidden neighbors #76

Open
ugurdogrusoz opened this issue Oct 12, 2016 · 8 comments
Open

Show hidden neighbors #76

ugurdogrusoz opened this issue Oct 12, 2016 · 8 comments

Comments

@ugurdogrusoz
Copy link
Contributor

ugurdogrusoz commented Oct 12, 2016

Add a new operation (at the very end) to the context menu of nodes (Show Hidden Neighbors) to show its hidden neighbors. So if A has 3 neighbors N1, N2, and N3, and N2 is currently visible but N1 and N3 aren't, and we issue this operation on A, we get N1 and N3 shown (unhidden) along with their incident edges, followed by an incremental layout call (we might need to put neighbors near the node as we unhide them so that incremental layout works better)!

@metincansiper
Copy link
Collaborator

I added this operation to ChiSE as described above.

@ugurdogrusoz
Copy link
Contributor Author

ugurdogrusoz commented Oct 13, 2016

This is great! Here are things that we need fix/improve:

  • Neighbours -> Neighbors (we consistently use US English)
  • Need to add the functionality to the View menu (View > Hide/Show > "Show Hidden Neighbors", right before "Show All")
  • If a transition is among nodes to be unhidden, we should find any other neighbor of that transition and unhide them as well to keep the transition intact!
  • If you choose synaptic cleft in the default diagram and hide it, and go to any one of its neighbors (e.g. SNARE in synaptic button) and call this operation nothing happens.
    Let's talk about how to cleanly implement the last two issues.
    We should transfer this new feature to the viewer as well!

metincansiper added a commit that referenced this issue Oct 13, 2016
@metincansiper
Copy link
Collaborator

I made these fixes other than the second one because I have confusion there. In context menu we know which node is on target and we can "Show Hidden Neighbors" of it. However, in the menu we do not have such a target. May it be "Show Hidden Neighbors of Selected" instead of "Show Hidden Neighbors".

@ugurdogrusoz
Copy link
Contributor Author

You re right, lets name as you suggested.

@ugurdogrusoz
Copy link
Contributor Author

Btw, I just tried show hidden neighbors for SNARE in default map after hiding the middle compartment. It unhides all of what's hidden but I was expecting only "processes of SNARE" (not the "other process" in that compartment).

metincansiper added a commit that referenced this issue Oct 13, 2016
@metincansiper
Copy link
Collaborator

metincansiper commented Oct 13, 2016

I added "Show Hidden Neighbors of Selected" to the View menu right before "Show All".

@ugurdogrusoz
Copy link
Contributor Author

ugurdogrusoz commented Oct 19, 2016

We also need to make sure hidden neighbors are initially placed (before incremental layout) near the node (this can wait!). Also need to transfer to the viewer.

@ugurdogrusoz ugurdogrusoz removed this from the version 1.0 milestone Sep 18, 2019
@ugurdogrusoz
Copy link
Contributor Author

We do this in Newt with the new extension. But is this or should this be exposed down in here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants