Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support forced-colors in all components and test for it #832

Open
FlyersPh9 opened this issue Dec 5, 2022 · 1 comment
Open

support forced-colors in all components and test for it #832

FlyersPh9 opened this issue Dec 5, 2022 · 1 comment
Labels
a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc) css Needs change in css package maintenance Related to development or technical debt or chores

Comments

@FlyersPh9
Copy link
Collaborator

FlyersPh9 commented Dec 5, 2022 •
edited by mayank99

Currently a few of our components support forced-colors mode. Ideally, all components will support it.

yarn test currently tests light, dark, light high contrast, and dark high contrast themes. It would be ideal if it also tested forced-colors mode. Was previously requested in #799.
@FlyersPh9 FlyersPh9 added the enhancement New feature or request label Dec 5, 2022
@FlyersPh9 FlyersPh9 mentioned this issue Dec 5, 2022
Closed
3 tasks
@FlyersPh9 FlyersPh9 added maintenance Related to development or technical debt or chores and removed enhancement New feature or request labels Dec 5, 2022
@mayank99 mayank99 changed the title yarn test includes forced-colors mode support forced-colors in all components and test for it Jun 16, 2023
@mayank99 mayank99 added a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc) css Needs change in css package good first issue Good for newcomers labels Jun 16, 2023
@mayank99 mayank99 removed the good first issue Good for newcomers label Feb 6, 2024
@mayank99
Copy link
Contributor

I've removed the "good first issue" label from this, because it requires big changes across all components. If this was only about testing forced-colors mode (with no widespread changes to component code), I would agree with the "good first issue" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc) css Needs change in css package maintenance Related to development or technical debt or chores
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FlyersPh9 @mayank99 @AdamMeza-Bentley