Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize configuration #4

Open
iGitScor opened this issue Oct 10, 2016 · 6 comments
Open

Externalize configuration #4

iGitScor opened this issue Oct 10, 2016 · 6 comments

Comments

@iGitScor
Copy link
Owner

For now, the global configuration (company name and contact) are set in the app.ts file and called directly in the layout file. It could be great to have a specific service.

layout.html

<div class="container">&copy; {{ company }}</div>
@mitesh-mutha
Copy link

Hi
I just came across this issue from Hacktoberfest.
What do you mean by "having a specific service" ? Could you elaborate.

@iGitScor
Copy link
Owner Author

iGitScor commented Oct 19, 2016

Hi @mitesh-mutha,

The idea was to have an angular2 service which load json configuration for example and inject to the application to display data in the layout.html template

The configuration in github have to be anonymous
configuration.json.dist
The installation documentation should mentioned the fact that the configuration.json.dist
has to be filled and duplicated as configuration.json

Feel free to ask me more question if the issue is not clear.

You can make any kind of proposal which respond to the issue

@mitesh-mutha
Copy link

@iGitScor Thanks !! I will have a look into angular2 services. If I have more questions on this issue I will ask you.
I am not in town for the next 3-4 days. Once I am back, I will let you know if I can contribute on this.

@iGitScor
Copy link
Owner Author

@mitesh-mutha, no worries, don't hesitate to tell us if you can always contribute to this issue

@iGitScor
Copy link
Owner Author

iGitScor commented Nov 6, 2016

@mitesh-mutha Hi, did you have time to work on this enhancement ?

@mitesh-mutha
Copy link

Not yet... Been busy... If someone else is interested they can pick it up. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants