Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using .lower_bound and .upper_bound for location in forward fit gives wrong results #198

Open
Muriel23 opened this issue Nov 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Muriel23
Copy link

Short Description
When defining upper and lower bounds for the location of sources for the forward fit routine, the sources are placed at the wrong location. Routine with issue: stx_vis_fwdfit_pso.pro

The Screenshots show the problem:
The two images above are done with the current GSW version. The boxes show the chosen upper and lower boundaries. Forwardfit at the right does not give correct results.
The two images below are done with a corrected version of stx_vis_fwdfit_pso.pro, written by @annavolp. This gives correct results for the source locations.
Screenshot from 2023-11-24 11-58-56

The new routine from @annavolp should be merged with the GSW. (This is needed for imaging spectroscopy)

Environment

  • STIX GSW Version (Nov. 2023)
@Muriel23 Muriel23 added the bug Something isn't working label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant