Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STX_CONSTRUCT_CALIBRATED_VISIBILITY #163

Open
JSGH2020 opened this issue May 2, 2023 · 1 comment
Open

STX_CONSTRUCT_CALIBRATED_VISIBILITY #163

JSGH2020 opened this issue May 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@JSGH2020
Copy link

JSGH2020 commented May 2, 2023

Short Description

When calling STX_CONSTRUCT_CALIBRATED_VISIBILITY with an L1 file that contains only a single timebin and a timerange that covers this timebin only partially, it will crash without providing any information. I think it should either print an appropriate statement or adjust the timerange to cover the entire timebin of the L1 file.

Details

% TRANSPOSE: Value of <INT Array[3]> is out of allowed range.
% Execution halted at: STX_PLOT_SELECTED_TIME_RANGE 83 C:\Program0Files\Harris\IDL86\so\stix\idl\processing\pixel_data\stx_plot_selected_time_range.pro
% STX_CONSTRUCT_PIXEL_DATA 181 C:\Program0Files\Harris\IDL86\so\stix\idl\processing\pixel_data\stx_construct_pixel_data.pro
% STX_CONSTRUCT_PIXEL_DATA_SUMMED 66 C:\Program0Files\Harris\IDL86\so\stix\idl\processing\pixel_data\stx_construct_pixel_data_summed.pro
% STX_CONSTRUCT_VISIBILITY 93 C:\Program0Files\Harris\IDL86\so\stix\idl\processing\vis\stx_construct_visibility.pro
% STX_CONSTRUCT_CALIBRATED_VISIBILITY 87 C:\Program0Files\Harris\IDL86\so\stix\idl\processing\vis\stx_construct_calibrated_visibility.pro

exampleFiles.zip

Environment

  • IDL Version: 8.6.0
  • STIX GSW Version: v0.4.0
  • OS: W11
@JSGH2020 JSGH2020 added the bug Something isn't working label May 2, 2023
@paolomassa
Copy link
Collaborator

Thanks @JSGH2020 for reporting this issue!

I will open a pull request soon with a solution to this problem. As a temporary solution, you could set /silent when you use 'stx_construct_calibrated_visibility', so that it does not use 'stx_plot_selected_time_range'.

samaloney pushed a commit that referenced this issue May 11, 2023
@paolomassa @samaloney
Fixed bug - Issue #163
efabc29 
If the science fits files contains a single time bin, do not call 'stx_plot_selected_time_range' since it crashes. There is no need to fix 'stx_plot_selected_time_range', as displaying the light curve is useless when there is a single time bin.
grazwegian added a commit to grazwegian/STIX-GSW that referenced this issue May 23, 2023
@grazwegian
Merge branch 'main' into XSPEC-conversion
e2a3579 
* main:
  stx_transmission: direct xcom calculation updated to use Be and Al alloys
  Fixed bug - Issue i4Ds#163
  Replaced nominal focal length with actual distance from lens to aperture plate
  Update README.md - correction of a little bug
  Update README.md - Who to contact
  Preparing a new release
  Update routines for L1 FITS file release.  (i4Ds#155)
grazwegian added a commit to grazwegian/STIX-GSW that referenced this issue Jul 11, 2023
@grazwegian
Merge branch 'main' into tungsten_l1
7383adc 
* main:
  stx_transmission: direct xcom calculation updated to use Be and Al alloys
  Fixed bug - Issue i4Ds#163
  Replaced nominal focal length with actual distance from lens to aperture plate
  Update README.md - correction of a little bug
  Update README.md - Who to contact
  Preparing a new release
  Update routines for L1 FITS file release.  (i4Ds#155)
  changed default of sumcase to TOP+BOT (i4Ds#153)
  Update grid seperation and detetor to rear grid values (i4Ds#151)
  Update README.md
  Update stx_vis_clean.pro
  Update stx_vis_clean
  Removed 'stx_vis_clean_psf' and fixed bug in 'vis_psf'
  Update 2.0 stx_science_data_lightcurve.pro
  Update stx_science_data_lightcurve.pro
  minor changes with sumcase - solves issue i4Ds#139
  Data downloaded by 'stx_imaging_demo' have been removed
  Clean update: fixed bug in the iterative loop and in the use of 'uniform weighting'
  Multiple functionalities added to stx_science_data_lightcurve: FITS files concatenation and sub-interval extraction
grazwegian added a commit to grazwegian/STIX-GSW that referenced this issue Jul 11, 2023
@grazwegian
Merge branch 'main' into tungsten-transmission
91c8842 
* main: (31 commits)
  stx_transmission: direct xcom calculation updated to use Be and Al alloys
  Fixed bug - Issue i4Ds#163
  Replaced nominal focal length with actual distance from lens to aperture plate
  Update README.md - correction of a little bug
  Update README.md - Who to contact
  Preparing a new release
  Update routines for L1 FITS file release.  (i4Ds#155)
  changed default of sumcase to TOP+BOT (i4Ds#153)
  Update grid seperation and detetor to rear grid values (i4Ds#151)
  Update README.md
  Change DATE_BEG to DATE-BEG to as is now standard in L1 files.
  replace testing directory path
  stx_read_fits: changed L1A warning as current software is only compatible with L1 files.
  Updating URLs for L1 version
  Updated spectroscopy demo to use release L1 files.
  Updated stx_convert_xxx and spectrogram routines to handle release version of L1 FITS files.
  Update stx_vis_clean.pro
  Update stx_vis_clean
  Removed 'stx_vis_clean_psf' and fixed bug in 'vis_psf'
  Update 2.0 stx_science_data_lightcurve.pro
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paolomassa @JSGH2020