Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If 'sumcase' is set to 'ALL' but data not present for all pixels then imaging pipeline throws an error #152

Open
FredSchuller opened this issue Mar 28, 2023 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@FredSchuller
Copy link
Collaborator

There is at least one test in function stx_sum_pixel_data (maybe more in other places): if the actual pixel mask found in the data is not consistent with the value of 'sumcase' passed as argument, then it throws an error and stops.
The user can explicitly pass sumcase='TOP+BOT' as argument to some procedures, but for example not in stx_estimate_flare_location

A clean fix would be to change the action that results from that test, so that whatever pixels are available in the file are used instead of stopping execution.
A possibly quicker fix for 99% of the data acquired until now would be to use TOP+BOT instead of ALL as a default. This should be changed consistently (also in the comments) in all functions where it is used.
@paolomassa can you please look into that?

@FredSchuller FredSchuller added the bug Something isn't working label Mar 28, 2023
@grazwegian grazwegian added this to the Version 0.4.0 milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants