Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Karabo and it's dependencies against CUDA #530

Open
Lukas113 opened this issue Nov 29, 2023 · 3 comments
Open

Build Karabo and it's dependencies against CUDA #530

Lukas113 opened this issue Nov 29, 2023 · 3 comments
Labels
enhancement New feature or request prio-med Medium priority

Comments

@Lukas113
Copy link
Collaborator

Lukas113 commented Nov 29, 2023

After reading conda cuda builds, I think we should do the same (if I understood the article correctly, please correct me if I may have misunderstood something). This would have the following advantages I think:

  • We wouldn't rely on a specific toolkit-version where some users might have issues if they a gpu-driver which is not up to date (even though the minimum required driver-version is only dependent on the major version of cuda-toolkit (see cuda compatibility).
  • We wouldn't have to worry about fixed-toolkit which could constrain us on which package & version we intend to include

This would imply changing the conda-build recipe of karabo and cuda-enabled packages of the Feedstock as well as changing the github-workflows and the dockerfiles.

@Lukas113 Lukas113 added enhancement New feature or request prio-med Medium priority labels Nov 29, 2023
@sfiruch
Copy link
Member

sfiruch commented Dec 5, 2023

Wouldn't this mean we'd have to test against all CUDA versions?

Using the oldest-possible CUDA versions means we're compatible with most drivers. That looks like a win. This proposal would result in Karabo crashes for users with out-of-date drivers.

@Lukas113
Copy link
Collaborator Author

Lukas113 commented Dec 6, 2023

If we can test against CUDA (which we don't do at the moment because the CI doesn't have GPUs), I think we shouldn't have to care about the toolkit-version because conda should identify the highest compatible version according to the documentation.

@Lukas113
Copy link
Collaborator Author

Lukas113 commented Dec 6, 2023

That's at least my understanding about the text written in conda cuda builds I've posted in the first comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prio-med Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants