Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Detection is restructured #528

Open
kenfus opened this issue Nov 22, 2023 · 0 comments
Open

Source Detection is restructured #528

kenfus opened this issue Nov 22, 2023 · 0 comments
Labels
prio-med Medium priority proj-source-detection Workflow: Source Detection

Comments

@kenfus
Copy link
Member

kenfus commented Nov 22, 2023

Currently, Source Detection is quite wierd:

  • you call detected sources in image on a class called SourceDetectionResult, which returns itself, but this time with the detected sources as an attribute.
  • Usage of cls makes maybe the code more clean but overall less readable.
  • Thanks to parallelization, there is now a class, which inherits from a class, which inherits from a class and one of them returns itself with cls, but actually you call a function, which this class does not have but inherits this from another class.

Thing should be split:

  • One class called SourceDetection, which results SourceDetectionResult with the results.

Other improvements:

  • No intermediate files are being kept, if they are not needed (such as source.csv).
  • Clean up better after source detection.
@kenfus kenfus added proj-source-detection Workflow: Source Detection prio-med Medium priority labels Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-med Medium priority proj-source-detection Workflow: Source Detection
Projects
None yet
Development

No branches or pull requests

1 participant