Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x_draw_decoration should fill pixmap before starting to draw #3481

Closed
Airblader opened this issue Oct 26, 2018 · 0 comments · Fixed by #4280, #4308 or #4336
Closed

x_draw_decoration should fill pixmap before starting to draw #3481

Airblader opened this issue Oct 26, 2018 · 0 comments · Fixed by #4280, #4308 or #4336
Labels
4.15 bug reproducible A bug that has been reviewed and confirmed by a project contributor

Comments

@Airblader
Copy link
Member

Airblader commented Oct 26, 2018 •
edited

I'm submitting a…

[x] Bug
[ ] Feature Request
[ ] Documentation Request
[ ] Other (Please describe in detail)

Current Behavior

In x_draw_decoration, we simply draw our decoration to the surface.

Expected Behavior

To avoid issues with clients like xeyes using Shape, we should fill the surface first (e.g., with black) to avoid visual garbage. See #2742 (comment) for details.

Note that this issue becomes void if #3479 is implemented first.

Environment

i3 4.15
@Airblader Airblader added bug missing-log Read the CONTRIBUTING.md file for instructions reproducible A bug that has been reviewed and confirmed by a project contributor 4.15 labels Oct 26, 2018
@Airblader Airblader mentioned this issue Oct 26, 2018
Closed
@Airblader Airblader mentioned this issue Nov 3, 2018
Closed
@Airblader Airblader mentioned this issue Jan 4, 2019
Closed
@tbgiles tbgiles mentioned this issue Dec 8, 2020
Merged
@orestisfl orestisfl reopened this Jan 3, 2021
@orestisfl orestisfl mentioned this issue Jan 3, 2021
Merged
@tbgiles tbgiles mentioned this issue Jan 3, 2021
Merged
orestisfl pushed a commit that referenced this issue Jan 3, 2021
@tbgiles
Clear framebuffer before drawing borders (#4308)
057a635 
Clear framebuffer before copying surface to prevent visual garbage

Fixes #3481
Corrects problems of #4280
@orestisfl orestisfl reopened this Jan 25, 2021
@orestisfl orestisfl removed good first issue missing-log Read the CONTRIBUTING.md file for instructions labels Jan 26, 2021
@tbgiles tbgiles mentioned this issue Jan 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.15 bug reproducible A bug that has been reviewed and confirmed by a project contributor
Projects
None yet
Milestone
No milestone
2 participants
@Airblader @orestisfl