focus left/right not giving focus to fullscreen windows

[foxxx0]

There seems to be a bug/regression in the 4.15 release.
The issue described below does not happen in the previous 4.14.1 release.

In Multi-Head setups the "focus left/right" command does not focus a
fullscreen window.
Instead it gives focus to the windows beneath that fullscreen window.

This problem does not happen when using "workspace ".
Here the fullscreen window will get focused properly.

For the debug logfiles I have cleaned up my i3 configuration a bit
and used that same config file in both versions.

Affected version:

Binary i3 version:  4.15 (2018-03-10) © 2009 Michael Stapelberg and contributors
Running i3 version: 4.15 (2018-03-10) (pid 18436) abort…)
Loaded i3 config: /home/fox/.config/i3/config (Last modified: Sun 25 Mar 2018 10:56:09 AM CEST, 573 seconds ago)

The i3 binary you just called: /usr/bin/i3
The i3 binary you are running: i3

Unaffected version:

Binary i3 version:  4.14.1 (2017-09-24) © 2009 Michael Stapelberg and contributors
Running i3 version: 4.14.1 (2017-09-24) (pid 15832)bort…)
Loaded i3 config: /home/fox/.config/i3/config (Last modified: Sun 25 Mar 2018 10:56:09 AM CEST, 884 seconds ago)

The i3 binary you just called: /usr/bin/i3
The i3 binary you are running: i3

URL to a logfile as per https://i3wm.org/docs/debugging.html:

Affected version (4.15) : https://paste.foxxx0.de/PYjjR/
Unaffected version (4.14.1) : https://paste.foxxx0.de/2um/

What I did:

For clarification purposes (regarding the logfile and the steps to reproduce),
the following assumptions are used:

• The primary output is "DisplayPort-2", aliased as "primary"
• The secondary output is "DisplayPort-3", aliased as "secondary"
• The secondary output is located left of the primary output
• Workspace "2: term" is on the primary output, aliased as "fullscreen"
• Workspace "4: mail" is on the secondary output, aliased as "foobar"

1. Open a window (termite) on the "fullscreen" workspace on the primary output
2. Switch to a workspace on a different output (workspace "foobar" on the secondary output)
3. Open two windows (termite, termite) there
4. Switch back to the "fullscreen" workspace on the primary output
5. Open another window a put it into fullscreen mode (I used mpv and played a video)
6. Use "focus left" to switch to the "foobar" workspace on the secondary output
7. Use "focus right" to switch back to the "fullscreen" workspace on the primary output

What I saw:

i3 changed focus to the window BELOW the fullscreen window.

What I expected instead:

Focus should be given to the fullscreen window.

[i3bot]

I don’t see a link to logs.i3wm.org. Did you follow https://i3wm.org/docs/debugging.html? (In case you actually provided a link to a logfile, please ignore me.)

[orestisfl]

An important detail is that the window from step 5. is floating.

[foxxx0]

Yes, in this case mpv starts in floating mode due to my for_window rule.
After that it is switched to fullscreen.

[orestisfl]

bisect: af78331 <--- blame this guy

[Airblader]

I know that guy, he'll probably send a PR soon to fix it :-)