Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: $mod+r toggles resize mode #3034

Closed
jchook opened this issue Oct 31, 2017 · 5 comments
Closed

Enhancement: $mod+r toggles resize mode #3034

jchook opened this issue Oct 31, 2017 · 5 comments
Labels
4.14 accepted Has been approved and is ok to start working on enhancement

Comments

@jchook
Copy link
Contributor

jchook commented Oct 31, 2017

Why not change the meaning of $mod+r from "enable resize mode" to "toggle resize mode"?

I believe this is a more desirable and intuitive UX as you can "exit through the door you entered".

Here is my attempt at making the change.

@jchook
Copy link
Contributor Author

jchook commented Oct 31, 2017

Wanted to quickly add that this pattern is already found throughout i3's defaults:

  1. $mod+f both enables and disables full-screen
  2. $mod+e will toggle between splits
  3. $mod+Shift+space toggles between floating and not
  4. workspace_auto_back_and_forth is not a default, but highlighted in the docs.

This last one is interesting because the docs touch on the philosophy behind the design decision:

For instance: Assume you are on workspace "1: www" and switch to "2: IM" using mod+2 because somebody sent you a message. You don’t need to remember where you came from now, you can just press $mod+2 again to switch back to "1: www".

@disconsis
Copy link

disconsis commented Nov 11, 2017

Cool idea, but I don't see why that would need to be specifically implemented.
You can configure it for yourself by putting bindsym $mod+r mode "default" inside mode "resize" {...}

@jchook
Copy link
Contributor Author

jchook commented Nov 11, 2017

IMO this is a UX improvement, not a preference. After reading about window mangers, it's surprisingly clear that a very significant reason people choose i3 (over Xmonad, etc) is for its superior default behavior.

Since resize appears to be the only pre-configured mode, it also sets an important precedent for general mode toggling behavior.

I'll also add that it is at no cost to you as I have already made the change and it's ready for a PR.

@Airblader
Copy link
Member

but I don't see why that would need to be specifically implemented.

It doesn't; the proposed change is just a change to the default config.

@jchook The proposal sounds good to me. Assuming @stapelberg doesn't object, I'll be happy to wait for the PR.

@Airblader Airblader added 4.14 accepted Has been approved and is ok to start working on labels Nov 11, 2017
@stapelberg
Copy link
Member

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.14 accepted Has been approved and is ok to start working on enhancement
Projects
None yet
Development

No branches or pull requests

5 participants