Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: dedupe content between t.d.ts and t.v4.d.ts #2148

Open
marcalexiei opened this issue Feb 24, 2024 · 4 comments
Open

refactor: dedupe content between t.d.ts and t.v4.d.ts #2148

marcalexiei opened this issue Feb 24, 2024 · 4 comments
Assignees

Comments

@marcalexiei
Copy link
Member

At the moment maintaining these two files in sync is a bit painful.
I would like to move the shared content in separate files to reduce maintenance efforts.

Obviously I hope that sometime, in the future, we can remove typescript v4 support 😅


Moved to a new issue from #2142 to avoid having tasks involving total different aspects of the project (CI vs typescript)

@marcalexiei
Copy link
Member Author

marcalexiei commented Mar 7, 2024

I just noticed that in the typescript documentation is stated that typescript v4 is no longer supported:

https://www.i18next.com/overview/typescript

The newest i18next versions only support TypeScript v5. Older TypeScript versions are not supported any longer with i18next > v23.
To use it with TypeScript v4, use i18next@22.5.1.

This change was made in November with this commit: i18next/i18next-gitbook@106f867

So I'm wondering if we can drop v4 support from the codebase, which implies:

  • remove t.v4.d.ts
  • typesVersion in package.json
  • maybe something else?

@marcalexiei
Copy link
Member Author

@adrai what so you think about this?

@adrai
Copy link
Member

adrai commented Mar 12, 2024

Sorry, missed your question completely...
My gut feeling tells me, we should keep the v4 support at least a little bit more... but we don't need to make sure all types functionality is in line with v5 if not possible...

@marcalexiei
Copy link
Member Author

Sorry, missed your question completely...

No problem 🙂


My gut feeling tells me, we should keep the v4 support at least a little bit more... but we don't need to make sure all types functionality is in line with v5 if not possible...

Gotcha. I'll leave this open open as a reminder to do that in the future 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants