Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove solution style tsconfig #1976

Open
cseas opened this issue Dec 29, 2022 · 1 comment
Open

Remove solution style tsconfig #1976

cseas opened this issue Dec 29, 2022 · 1 comment

Comments

@cseas
Copy link
Contributor

cseas commented Dec 29, 2022

Use Case

The solution style tsconfig was added to the project as part of an upgrade to Angular 10 but this change was rolled back soon after in the next patch release.

The project is now on Angular 12 but still has the solution style tsconfig. This file should've been removed as part of Angular 10 minor update.

Keeping this file around is going to cause issues upgrading packages since Angular packages throw an error if tsconfig.base.json is present in the project. Example

Proposal

Remove the solution style tsconfig. Simply deleting the file will throw typescript errors in VSCode in random file (e.g. explorer.component.test.ts) so replacement config needs to be setup where required.

@cseas cseas changed the title Remove splution style tsconfig Remove solution style tsconfig Dec 29, 2022
@cseas
Copy link
Contributor Author

cseas commented Dec 29, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant