Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Time and End Time filters doesn’t show invalid input message in explorer #1282

Open
jyothishjose6190 opened this issue Nov 23, 2021 · 3 comments

Comments

@jyothishjose6190
Copy link
Contributor

jyothishjose6190 commented Nov 23, 2021

Guessing that they are doing some internal validation Any incorrect input should show some toast with validation error details.
Screenshot 2021-11-24 at 9 05 46 AM

@aaron-steinfeld
Copy link
Contributor

Can you elaborate? What's not working? This screenshot looks to be on the trace list of an endpoint rather than explorer (although they work more or less the same way).

We don't frequently filter by these explicitly since we instead adjust the time range, but they should work and did when I just tested locally. They're pretty inconvenient since working with the attributes directly like that means you're working in their native format, epoch millis.

image

@jyothishjose6190 jyothishjose6190 changed the title Start Time and End Time filters doesn’t work in explorer Start Time and End Time filters doesn’t show invalid input message in explorer Nov 24, 2021
@jyothishjose6190
Copy link
Contributor Author

@aaron-steinfeld when we enter invalid input, for example, start time filter without any value, it's not showing any error message. is it the expected behavior?
Screenshot 2021-11-24 at 9 05 46 AM

@aaron-steinfeld
Copy link
Contributor

It's the implemented behavior for all filters (if the filter is left in an incomplete/invalid state, it's left that way to be finished later), but agree the UX isn't great. Do you mind updating this ticket to capture this general improvement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants