Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate message key in kafka-exporter #10

Open
findingrish opened this issue Jan 12, 2021 · 5 comments
Open

Populate message key in kafka-exporter #10

findingrish opened this issue Jan 12, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@findingrish
Copy link

findingrish commented Jan 12, 2021

Currently the paltform receives messages with key as null, can the collector set the key as TenantId (default value in case it is not set) + TraceId instead (similar to https://github.com/hypertrace/hypertrace-ingester/blob/main/span-normalizer/span-normalizer/src/main/java/org/hypertrace/core/spannormalizer/jaeger/JaegerSpanToAvroRawSpanTransformer.java#L50).

  1. There is going to be no downsides of doing this
  2. This could potentially allow us to directly group the span into Traces in the entry platform service (Remove span-normalizer service  hypertrace-ingester#59).

cc @jcchavezs @buchi-busireddy @kotharironak

@pavolloffay
Copy link
Member

pavolloffay commented Feb 4, 2021

Currently the paltform receives messages with key as null,

by currently do you mean when using the OpenCensus service or this collector?

@findingrish
Copy link
Author

by currently do you mean when using the OpenCensus service or this collector?

OC collector

@pavolloffay
Copy link
Member

Alright so this is a new feature request. I thought there is a regression between OC kafka exporter and OTEL collector.

@pavolloffay pavolloffay added the enhancement New feature or request label Feb 4, 2021
@pavolloffay
Copy link
Member

Would it be enough to use the TraceID without tenant as the key?

The kafka exporter code is in OTEL collector. Adding traceID as a key might seem feasible, however the collector upstream does not have a concept of tenantID.

@jcchavezs
Copy link
Contributor

yeah, tenant_id feels more like a non hypertrace concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants