Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving 1-D Ragged Dask Arrays aren't supported for .hspy #198

Open
CSSFrancis opened this issue Dec 12, 2023 · 0 comments
Open

Saving 1-D Ragged Dask Arrays aren't supported for .hspy #198

CSSFrancis opened this issue Dec 12, 2023 · 0 comments

Comments

@CSSFrancis
Copy link
Member

This is the issue tracker for the incompatibility found in #193 with saving 1d dask arrays of objects using the h5py package.

The problem appears to be a mis-match related to the size of the h5py.Dataset and the dask array. This is most likely from some casting done by h5py as it doesn't appear in the zarr library. For example https://github.com/h5py/h5py/blob/4c01efa9714db40ffe27a322c4f1ba4635816e44/h5py/_hl/selections.py#L236-L249 casts to make sure that the Dataset and the array are the same shape.

Describe the functionality you would like to see.

It would be good to fix this problem eventually, either by finding the bug (potentially in h5py) or by finding a way around it. We could potentially just up cast the array from (N,) to (N,1) save and then squeeze the array after loading. That is a little hacky and I would like to avoid it.

Describe the context

You can save this type of array with the .zspy format so in most cases I would just recommend using that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant