Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZLP alignment very slow #83

Open
thomasaarholt opened this issue Dec 8, 2016 · 6 comments
Open

ZLP alignment very slow #83

thomasaarholt opened this issue Dec 8, 2016 · 6 comments

Comments

@thomasaarholt
Copy link
Contributor

thomasaarholt commented Dec 8, 2016

I thought this might be a hyperspy and matplotlib-backend related issue, but perhaps not.

Trying zlp alignment in HyperspyUI (using the console) is extremely slow - I think this is due to the matplotlib backend, although I'm not sure why. @Andyroo and I discovered that there was a big time delay on align1D depending if one was in inline or qt4.
The following 1.8 GB lowloss image takes 1.5 min to align in normal hyperspy (inline).
Hyperspyui estimates 91 hours. This is with the "view" of the SI off. Typing %matplotlib inline in the UI console makes the images dissappear, but the alignment takes the same amount of time.

@vidartf
Copy link
Member

vidartf commented Dec 8, 2016

I'm going to assume that it tries to plot during fitting of the ZLP. Try suppressing plotting calls from events temporarily during plotting, to see if that has an effect.

@thomasaarholt
Copy link
Contributor Author

Whatever you've done over the past month has improved the situation, but it is still about 30 times faster in hs than in the UI.

An oddity is that the three-stage zlp alignment with subpixel correction takes 5 sec, 13 sec and 5 sec for each stage in hyperspy, but 1.5min, 0.5min and 7.5 min in the UI.

Looks like there's something happening with the first and last process that takes a long time in the UI whilst the middle process has fewer things slowing it down in the UI.

@vidartf
Copy link
Member

vidartf commented Jan 18, 2017

There is not really anything that the UI should do to slow this down. Are you using the qt4 backend in normal hyperspy? That should be the same speed as int the UI.

@vidartf
Copy link
Member

vidartf commented Jan 23, 2017

I think it might be related to the progress bar code. I'll I've at least been able to reproduce it locally, and will have a look.

@thomasaarholt
Copy link
Contributor Author

thomasaarholt commented Apr 21, 2017

Nice and fast now.

@vidartf
Copy link
Member

vidartf commented Apr 21, 2017

I haven't done anything, so why does it currently work?

@vidartf vidartf reopened this Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants