Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we pack public keys with signatures? #4393

Open
mversic opened this issue Mar 28, 2024 · 0 comments · May be fixed by #4518
Open

Should we pack public keys with signatures? #4393

mversic opened this issue Mar 28, 2024 · 0 comments · May be fixed by #4518
Assignees
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Milestone

Comments

@mversic
Copy link
Contributor

mversic commented Mar 28, 2024

our Signature is represented as:

pub struct Signature {
    public_key: PublicKey,
    payload: ConstVec<u8>,
}

but in the case that we know who's signed the message having public_key in the signature is unnecessary. It is unnecessary because the verifier still has to know what public key it expects in the signature. I noticed this due to the fact that we require a key pair to sign genesis. In that case there is only 1 signee and there can't be any doubt as to what public key must have been used.

Another example is the consensus. We don't have to send full blown public key with every signature. Since all nodes have to agree on the topology I think it is sufficient to just send index of the node in the current topology

I'm not sure what we can do with MST

@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested labels Mar 28, 2024
@mversic mversic self-assigned this Apr 22, 2024
@mversic mversic removed the question Further information is requested label Apr 24, 2024
@mversic mversic added this to the 2.0.0-rc.1 milestone Apr 24, 2024
mversic added a commit to mversic/iroha that referenced this issue Apr 26, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic linked a pull request Apr 26, 2024 that will close this issue
5 tasks
mversic added a commit to mversic/iroha that referenced this issue Apr 26, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 26, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 26, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic added a commit to mversic/iroha that referenced this issue Apr 27, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant