Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Trigger is not callable by multiple users (stable) #4418

Open
Erigara opened this issue Apr 11, 2024 · 2 comments
Open

[BUG]: Trigger is not callable by multiple users (stable) #4418

Erigara opened this issue Apr 11, 2024 · 2 comments
Assignees
@Erigara @AlexStroke
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@Erigara
Copy link
Contributor

Erigara commented Apr 11, 2024

THIS ISSUE ALREADY FIXED ON LATEST iroha2-dev branch, however we should consider backport.

On the iroha2-stable branch, it's possible to call trigger only by single user.

This happens because ExecuteTriggerEventFilter allows accept only single account.

Solution would be to accept either single user or any user (permission to execute should be checked by executor).
@Erigara Erigara added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 11, 2024
@mversic
Copy link
Contributor

mversic commented Apr 15, 2024

has this backport been requested by anyone?

@Erigara
Copy link
Contributor Author

Erigara commented Apr 15, 2024

yes, it was requested by CBDC team (after discussion with @Stukalov-A-M).

@Erigara Erigara self-assigned this Apr 22, 2024
Erigara added a commit to Erigara/iroha that referenced this issue Apr 22, 2024
@Erigara
[fix] hyperledger#4418: Trigger is callable by multiple users
ae4089e 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara mentioned this issue Apr 22, 2024
Merged
mversic pushed a commit that referenced this issue Apr 22, 2024
@Erigara
[fix] #4418: Trigger is callable by multiple users (#4491)
ca37b7f 
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@AlexStroke AlexStroke self-assigned this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Erigara Erigara

@AlexStroke AlexStroke

Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Erigara @mversic @AlexStroke