Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Dedup public keys in transaction.signature and transaction.payload.authority #4410

Open
s8sato opened this issue Apr 4, 2024 · 0 comments
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@s8sato
Copy link
Contributor

s8sato commented Apr 4, 2024

As of [commit hash] there is a duplication between transaction.signature.public_key and transaction.payload.authority.signatory.
The former could also serve as the latter role, but the problem is that authority: AccountId is required for subsequent process and it consists of not only public key but also DomainId which cannot be known from transaction.signature.
The solution would be to drive DomainId out of AccountId, but the main blocker is that AccountId should inform of its parent domain for event scoping.
So the first step would be to retrieve DomainId somewhere other than AccountId at the account event emission

@s8sato s8sato added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

No branches or pull requests

1 participant