Refactor config usage in integration tests #4383
Labels
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Refactor
Improvement to overall code quality
Comments
0x009922
added
iroha2-dev
0x009922
added a commit
to 0x009922/iroha
that referenced
this issue
Mar 25, 2024
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
0x009922
added a commit
that referenced
this issue
Mar 26, 2024
…uration (#4377) * [chore] #4323: remove `iroha_config/tokio-console` feature Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [chore]: format Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [refactor]: re-arrange telemetry features - remove `tokio_console_address` configuration - leverage default ENVs for tokio console config - `iroha_logger/tokio-console` feature fully controls whether it is enabled - refactoring chores Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [test]: fixes Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [chore]: repair `Cargo.toml` Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [chore]: repair `Cargo.toml` (how often should I?) Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [refactor]: `[telemetry.dev]` to `[dev_telemetry]` Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [build]: fix Iroha build with `--no-default-features` Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [refactor]: move args tests to `lib.rs` Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [feature]: add cargo features into `iroha --version` Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [feature]: improve logging a bit Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [feature]: `mkdir -r` for `dev_telemetry.out_file` Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [feature]: improve validation of paths in config Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [fix]: add `\n` separator to file telemetry logs Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [chore]: update snapshot logs Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [fix]: use `write_all` again Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [fix]: disable `genesis.file` validation (#4383) Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [test]: remove telemetry features from integration tests Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> * [chore]: revert "WSV" logs Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com> --------- Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Namely,
impl TestConfig for Configandiroha::samples::get_user_configiroha/core/test_network/src/lib.rs
Line 766 in e1e8a1a
iroha/cli/src/samples.rs
Line 62 in 50b5bc2
The use of configuration in tests is limited and unlikely to require building the user layer of it. As configuration validation logic (e.g. validating that
genesis.fileexists), these parts start to fall.To be less abstract, I propose to refactor these parts to use the config in a way that is valid in tests and will not rely on what is not designed for tests. For example, it doesn't make sense to specify
genesis.filein a test config when it will be never read there.Related:
The text was updated successfully, but these errors were encountered: