Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genesis transactions inconsistency #3863

Closed
mversic opened this issue Sep 4, 2023 · 1 comment
Closed

Genesis transactions inconsistency #3863

mversic opened this issue Sep 4, 2023 · 1 comment
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested

Comments

@mversic
Copy link
Contributor

mversic commented Sep 4, 2023

This is how genesis block is represented in the schema:

  "RawGenesisBlock": {
    "Struct": [
      {
        "name": "transactions",
        "type": "Vec<Vec<InstructionBox>>"
      },
      {
        "name": "validator",
        "type": "ValidatorMode"
      }
    ]
  }

First of all it's not composed of transactions, but of a double list of instructions. Either we should make it a single vector of instructions like this (notice rename from transactions -> instructions):

  "RawGenesisBlock": {
    "Struct": [
      {
        "name": "instructions",
        "type": "Vec<InstructionBox>"
      },
      {
        "name": "validator",
        "type": "ValidatorMode"
      }
    ]
  }

or we're going to use a proper transaction

  "RawGenesisBlock": {
    "Struct": [
      {
        "name": "transactions",
        "type": "Vec<VersionedSignedTransaction>"
      },
      {
        "name": "validator",
        "type": "ValidatorMode"
      }
    ]
  }
@mversic mversic added iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested labels Sep 4, 2023
@mversic mversic added the good first issue Good for newcomers label Dec 7, 2023
@mversic
Copy link
Contributor Author

mversic commented Jan 24, 2024

superseeded by #4225

@mversic mversic closed this as completed Jan 24, 2024
@nxsaken nxsaken closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants